Issue 130390044: code review 130390044: cmd/api: add missing runtime struct

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 130390044: code review 130390044: cmd/api: add missing runtime struct (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by dvyukov

Modified:
11 years, 3 months ago

Reviewers:
khr1

CC:
golang-codereviews, khr

Visibility:
Public.

Description

cmd/api: add missing runtime struct Fixes build.

Patch Set 1 #

Patch Set 2 : diff -r cac5e200314bf8714021cd7a3bc52cd144e37e0f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r cac5e200314bf8714021cd7a3bc52cd144e37e0f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r cac5e200314bf8714021cd7a3bc52cd144e37e0f https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/api/goapi.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-codereviews@googlegroups.com (cc: khr@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

11 years, 3 months ago (2014-08-21 07:42:23 UTC) #1

dvyukov

*** Submitted as https://code.google.com/p/go/source/detail?r=60fa2aa366ab *** cmd/api: add missing runtime struct Fixes build. TBR=khr R=golang-codereviews CC=golang-codereviews, ...

11 years, 3 months ago (2014-08-21 07:44:04 UTC) #2

khr1

11 years, 3 months ago (2014-08-21 15:57:57 UTC) #3

LGTM.


On Thu, Aug 21, 2014 at 12:44 AM, <dvyukov@google.com> wrote:

> *** Submitted as
> https://code.google.com/p/go/source/detail?r=60fa2aa366ab ***
>
>
> cmd/api: add missing runtime struct
> Fixes build.
>
> TBR=khr
> R=golang-codereviews
> CC=golang-codereviews, khr
> https://codereview.appspot.com/130390044
>
>
> https://codereview.appspot.com/130390044/
>

Expand All Messages | Collapse All Messages