Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(762)

Issue 13037043: code review 13037043: runtime: impose thread count limit (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by rsc
Modified:
4 years, 3 months ago
Reviewers:
dvyukov
CC:
golang-dev, r, dvyukov
Visibility:
Public.

Description

runtime: impose thread count limit Actually working to stay within the limit could cause subtle deadlocks. Crashing avoids the subtlety. Fixes issue 4056.

Patch Set 1 #

Patch Set 2 : diff -r aeb72c90c10e https://code.google.com/p/go/ #

Total comments: 1

Patch Set 3 : diff -r 06593199ff39 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -1 line) Patch
M src/pkg/runtime/crash_test.go View 1 2 chunks +30 lines, -0 lines 0 comments Download
M src/pkg/runtime/debug/garbage.go View 1 2 2 chunks +19 lines, -0 lines 0 comments Download
M src/pkg/runtime/proc.c View 1 5 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-dev@googlegroups.com (cc: dvyukov), I'd like you to review this change to https://code.google.com/p/go/
4 years, 3 months ago (2013-08-16 03:15:36 UTC) #1
r
Will this mean our sheets will never be silky smooth? -rob
4 years, 3 months ago (2013-08-16 04:42:04 UTC) #2
rsc
Not unless you call debug.SetMaxThreads(2000).
4 years, 3 months ago (2013-08-16 05:09:50 UTC) #3
dvyukov
LGTM https://codereview.appspot.com/13037043/diff/3001/src/pkg/runtime/debug/garbage.go File src/pkg/runtime/debug/garbage.go (right): https://codereview.appspot.com/13037043/diff/3001/src/pkg/runtime/debug/garbage.go#newcode133 src/pkg/runtime/debug/garbage.go:133: func SetMaxThreads(bytes int) int { s/bytes/threads/
4 years, 3 months ago (2013-08-16 08:41:01 UTC) #4
rsc
4 years, 3 months ago (2013-08-17 02:25:30 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=b3ee0be87a1c ***

runtime: impose thread count limit

Actually working to stay within the limit could cause subtle deadlocks.
Crashing avoids the subtlety.

Fixes issue 4056.

R=golang-dev, r, dvyukov
CC=golang-dev
https://codereview.appspot.com/13037043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4