Issue 13037043: code review 13037043: runtime: impose thread count limit

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13037043: code review 13037043: runtime: impose thread count limit (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by rsc

Modified:
11 years, 3 months ago

Reviewers:
dvyukov

CC:
golang-dev, r, dvyukov

Visibility:
Public.

Description

runtime: impose thread count limit Actually working to stay within the limit could cause subtle deadlocks. Crashing avoids the subtlety. Fixes issue 4056.

Patch Set 2 : diff -r aeb72c90c10e https://code.google.com/p/go/ #

Total comments: 1

Patch Set 3 : diff -r 06593199ff39 https://code.google.com/p/go/ #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -1 line)			Patch
M	src/pkg/runtime/crash_test.go	View	1	2 chunks	+30 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/debug/garbage.go	View	1 2	2 chunks	+19 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/proc.c	View	1	5 chunks	+25 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com (cc: dvyukov), I'd like you to review this change to https://code.google.com/p/go/

11 years, 3 months ago (2013-08-16 03:15:36 UTC) #1

dvyukov

LGTM https://codereview.appspot.com/13037043/diff/3001/src/pkg/runtime/debug/garbage.go File src/pkg/runtime/debug/garbage.go (right): https://codereview.appspot.com/13037043/diff/3001/src/pkg/runtime/debug/garbage.go#newcode133 src/pkg/runtime/debug/garbage.go:133: func SetMaxThreads(bytes int) int { s/bytes/threads/

11 years, 3 months ago (2013-08-16 08:41:01 UTC) #4

rsc

11 years, 3 months ago (2013-08-17 02:25:30 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=b3ee0be87a1c ***

runtime: impose thread count limit

Actually working to stay within the limit could cause subtle deadlocks.
Crashing avoids the subtlety.

Fixes issue 4056.

R=golang-dev, r, dvyukov
CC=golang-dev
https://codereview.appspot.com/13037043

Expand All Messages | Collapse All Messages