Issue 13036043: code review 13036043: cmd/go: fix at least some instances of double compilation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13036043: code review 13036043: cmd/go: fix at least some instances of double compilation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by r

Modified:
11 years, 9 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/go: fix at least some instances of double compilation When the packages the tested package depends on don't build, we weren't getting out early. Added a simple check for a successful build to an existing early out. There may be other ways that double compilation arises, but this fixes the one listed in the issue. Fixes issue 5679

Patch Set 1 #

Patch Set 2 : diff -r f9fc4689c414 https://code.google.com/p/go/ #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/go/test.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 9 months ago (2013-08-16 02:48:06 UTC) #1

11 years, 9 months ago (2013-08-16 02:49:58 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=f6ab40335287 ***

cmd/go: fix at least some instances of double compilation

When the packages the tested package depends on don't build,
we weren't getting out early. Added a simple check for a successful
build to an existing early out.

There may be other ways that double compilation arises, but
this fixes the one listed in the issue.
Fixes issue 5679

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/13036043

Expand All Messages | Collapse All Messages