Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(374)

Issue 130200044: code review 130200044: runtime: fix memstats (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by dvyukov
Modified:
10 years, 7 months ago
Reviewers:
cookieo9, khr
CC:
golang-codereviews, khr, cookieo9, rlh, rsc
Visibility:
Public.

Description

runtime: fix memstats Newly allocated memory is subtracted from inuse, while it was never added to inuse. Span leftovers are subtracted from both inuse and idle, while they were never added. Fixes issue 8544. Fixes issue 8430.

Patch Set 1 #

Patch Set 2 : diff -r b86ee06ef235d5766845f44056f152e1808da110 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r b86ee06ef235d5766845f44056f152e1808da110 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r b86ee06ef235d5766845f44056f152e1808da110 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r b86ee06ef235d5766845f44056f152e1808da110 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r b86ee06ef235d5766845f44056f152e1808da110 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 7 : diff -r b86ee06ef235d5766845f44056f152e1808da110 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 8 : diff -r 71db3dc120afee10f9b0e8e91bd0f0d4ba97bcd7 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 9 : diff -r 71db3dc120afee10f9b0e8e91bd0f0d4ba97bcd7 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -13 lines) Patch
M src/pkg/runtime/malloc.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/runtime/malloc_test.go View 1 2 3 1 chunk +19 lines, -3 lines 0 comments Download
M src/pkg/runtime/mheap.c View 1 2 3 4 5 6 7 8 chunks +14 lines, -10 lines 0 comments Download

Messages

Total messages: 6
dvyukov
Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rlh@golang.org, rsc@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 7 months ago (2014-08-18 17:18:10 UTC) #1
dvyukov
Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com, khr@golang.org, rlh@golang.org, rsc@golang.org), Please take another look.
10 years, 7 months ago (2014-08-18 17:24:39 UTC) #2
khr
LGTM.
10 years, 7 months ago (2014-08-18 20:31:53 UTC) #3
cookieo9
The change to the scavenger debug lines breaks gcvis (https://github.com/davecheney/gcvis) which I was using for ...
10 years, 7 months ago (2014-08-18 22:52:48 UTC) #4
dvyukov
On 2014/08/18 22:52:48, cookieo9 wrote: > The change to the scavenger debug lines breaks gcvis ...
10 years, 7 months ago (2014-08-19 07:43:48 UTC) #5
dvyukov
10 years, 7 months ago (2014-08-19 07:46:11 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=11cb74101371 ***

runtime: fix memstats
Newly allocated memory is subtracted from inuse, while it was never added to
inuse.
Span leftovers are subtracted from both inuse and idle,
while they were never added.
Fixes issue 8544.
Fixes issue 8430.

LGTM=khr, cookieo9
R=golang-codereviews, khr, cookieo9
CC=golang-codereviews, rlh, rsc
https://codereview.appspot.com/130200044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b