code review 130200044: runtime: fix memstats

runtime: fix memstats
Newly allocated memory is subtracted from inuse, while it was never added to inuse.
Span leftovers are subtracted from both inuse and idle,
while they were never added.
Fixes issue 8544.
Fixes issue 8430.

[dvyukov, 2014-08-18 17:18:10]

Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rlh@golang.org,
rsc@golang.org),

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[dvyukov, 2014-08-18 17:24:39]

Hello golang-codereviews@googlegroups.com (cc:
golang-codereviews@googlegroups.com, khr@golang.org, rlh@golang.org,
rsc@golang.org),

Please take another look.

[khr, 2014-08-18 20:31:53]

LGTM.

[cookieo9, 2014-08-18 22:52:48]

The change to the scavenger debug lines breaks gcvis
(https://github.com/davecheney/gcvis) which I was using for some of my tests,
but otherwise the stats look to be correct for my programs.

LGTM

[dvyukov, 2014-08-19 07:43:48]

On 2014/08/18 22:52:48, cookieo9 wrote:
> The change to the scavenger debug lines breaks gcvis
> (https://github.com/davecheney/gcvis) which I was using for some of my tests,
> but otherwise the stats look to be correct for my programs.

I've reverted the format change.

[dvyukov, 2014-08-19 07:46:11]

*** Submitted as https://code.google.com/p/go/source/detail?r=11cb74101371 ***

runtime: fix memstats
Newly allocated memory is subtracted from inuse, while it was never added to
inuse.
Span leftovers are subtracted from both inuse and idle,
while they were never added.
Fixes issue 8544.
Fixes issue 8430.

LGTM=khr, cookieo9
R=golang-codereviews, khr, cookieo9
CC=golang-codereviews, rlh, rsc
https://codereview.appspot.com/130200044