Issue 130170043: code review 130170043: internal/syscall: add support for getrandom on arm

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 130170043: code review 130170043: internal/syscall: add support for getrandom on arm (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by bradfitz

Modified:
10 years, 4 months ago

Reviewers:
agl1, gobot

CC:
agl, agl1, golang-codereviews

Visibility:
Public.

internal/syscall: add support for getrandom on arm Added in linux commit eb6452537b28

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/pkg/internal/syscall/getrandom_linux.go	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4

bradfitz

Hello agl@chromium.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 4 months ago (2014-08-16 22:36:55 UTC) #1

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=0bf0f54fa7eb *** internal/syscall: add support for getrandom on arm Added in linux ...

10 years, 4 months ago (2014-08-18 18:19:06 UTC) #3

gobot

10 years, 4 months ago (2014-08-18 18:35:09 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the windows-386 builder.
See http://build.golang.org/log/0f4dd3b8bf55da07d852049d74b7177613c156f0