Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3524)

Issue 13010048: Acme Mail: support spaces in mail dir name

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by akumar
Modified:
10 years, 6 months ago
Reviewers:
rsc
CC:
rsc, d, 0intro, codebot
Visibility:
Public.

Description

Mail services (such as Google Mail) will often have directories with names that contain spaces. Acme does not support spaces in window names. So, replace spaces in mail directory names with the Unicode character for visible space. The code is a bit of an over-approximation and generally non-optimal.

Patch Set 1 #

Patch Set 2 : Second try. A bit more optimal: no longer allocate an entire rune string. #

Patch Set 3 : revised patch set 1 #

Patch Set 4 : add small comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M src/cmd/acme/mail/win.c View 1 2 3 1 chunk +16 lines, -1 line 0 comments Download

Messages

Total messages: 9
akumar
10 years, 7 months ago (2013-08-22 23:57:01 UTC) #1
akumar
10 years, 7 months ago (2013-08-23 23:00:43 UTC) #2
akumar
+du colombier I like the first patch-set more; let me know if you would like ...
10 years, 7 months ago (2013-08-26 01:36:57 UTC) #3
0intro
I'm much more in favor of the first patch.
10 years, 7 months ago (2013-08-27 07:06:39 UTC) #4
akumar
10 years, 7 months ago (2013-08-27 10:11:13 UTC) #5
akumar
10 years, 7 months ago (2013-08-27 10:12:21 UTC) #6
akumar
10 years, 7 months ago (2013-08-27 10:16:18 UTC) #7
rsc
LGTM
10 years, 6 months ago (2013-09-06 20:10:05 UTC) #8
rsc
10 years, 6 months ago (2013-09-06 20:10:28 UTC) #9
*** Submitted as
https://code.google.com/p/plan9port/source/detail?r=351b136aa394 ***

mailfs: allow spaces in box name

Mail services (such as Google Mail) will often have
directories with names that contain spaces. Acme
does not support spaces in window names. So, replace
spaces in mail directory names with the Unicode
character for visible space.

The code is a bit of an over-approximation and
generally non-optimal.

R=rsc, david.ducolombier, 0intro
CC=plan9port.codebot
https://codereview.appspot.com/13010048

Committer: Russ Cox <rsc@swtch.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b