Issue 13010048: Acme Mail: support spaces in mail dir name

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13010048: Acme Mail: support spaces in mail dir name

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by akumar

Modified:
11 years, 4 months ago

Reviewers:
rsc

CC:
rsc, d, 0intro, codebot

Visibility:
Public.

Description

Mail services (such as Google Mail) will often have directories with names that contain spaces. Acme does not support spaces in window names. So, replace spaces in mail directory names with the Unicode character for visible space. The code is a bit of an over-approximation and generally non-optimal.

Patch Set 1 #

Patch Set 2 : Second try. A bit more optimal: no longer allocate an entire rune string. #

Patch Set 3 : revised patch set 1 #

Patch Set 4 : add small comment #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	M	src/cmd/acme/mail/win.c	View	1 2 3	1 chunk	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 9

Expand All Messages | Collapse All Messages

akumar

+du colombier I like the first patch-set more; let me know if you would like ...

11 years, 4 months ago (2013-08-26 01:36:57 UTC) #3

rsc

11 years, 4 months ago (2013-09-06 20:10:28 UTC) #9

*** Submitted as
https://code.google.com/p/plan9port/source/detail?r=351b136aa394 ***

mailfs: allow spaces in box name

Mail services (such as Google Mail) will often have
directories with names that contain spaces. Acme
does not support spaces in window names. So, replace
spaces in mail directory names with the Unicode
character for visible space.

The code is a bit of an over-approximation and
generally non-optimal.

R=rsc, david.ducolombier, 0intro
CC=plan9port.codebot
https://codereview.appspot.com/13010048

Committer: Russ Cox <rsc@swtch.com>

Expand All Messages | Collapse All Messages