code review 13010047: go.crypto/ssh: Update Dial to perform remote resolution of DNS names.

go.crypto/ssh: Update Dial to perform remote resolution of DNS names.

[jpsugar, 2013-08-22 20:41:59]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.crypto

[jpsugar, 2013-08-26 19:16:56]

Ping? :-)

[agl1, 2013-08-26 19:21:17]

(Note: please cc me directly on reviews if you want me to see it as I can no
longer keep up with golang-dev.)

I'm not sure why this isn't the default behaviour for Dial(). Is there a solid
reason to resolve addresses locally?

[jpsugar, 2013-08-26 20:14:31]

On 2013/08/26 19:21:17, agl1 wrote:
> I'm not sure why this isn't the default behaviour for Dial(). Is there a solid
> reason to resolve addresses locally?

To provide a correct RemoteAddr() in the net.Conn. net.Addr is IP-only, no DNS.

[agl1, 2013-08-28 16:35:45]

On 2013/08/26 20:14:31, jpsugar wrote:
> On 2013/08/26 19:21:17, agl1 wrote:
> > I'm not sure why this isn't the default behaviour for Dial(). Is there a
solid
> > reason to resolve addresses locally?
> 
> To provide a correct RemoteAddr() in the net.Conn. net.Addr is IP-only, no
DNS.

That doesn't seem that compelling to me compared with the least-surprise of
having the resolution performed at the remote end. I looked in the RFC to see if
the resolution result was contained in the channel open confirm message, but it
doesn't appear to be specified.

[jpsugar, 2013-08-28 17:36:07]

On 2013/08/28 16:35:45, agl1 wrote:
> That doesn't seem that compelling to me compared with the least-surprise of
> having the resolution performed at the remote end. I looked in the RFC to see
if
> the resolution result was contained in the channel open confirm message, but
it
> doesn't appear to be specified.

I would love to change Dial, but I erred on the side of conservatism. Would you
like me to change Dial instead of adding DialRemote?

[agl1, 2013-08-28 19:39:58]

On Wed, Aug 28, 2013 at 1:36 PM,  <jpsugar@google.com> wrote:
> I would love to change Dial, but I erred on the side of conservatism.
> Would you like me to change Dial instead of adding DialRemote?

I think the balance between not changing anything and making things
work without surprise falls on the side of changing Dial.

It's close, but not changing something is given a lesser weight in subrepos.


Cheers

AGL

[jpsugar, 2013-08-28 20:30:56]

Hello agl@golang.org, golang-dev@googlegroups.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[jpsugar, 2013-08-28 20:49:34]

Updated change description.

[agl1, 2013-08-28 21:52:09]

*** Submitted as
https://code.google.com/p/go/source/detail?r=f41ee99a7f88&repo=crypto ***

go.crypto/ssh: Update Dial to perform remote resolution of DNS names.

R=agl
CC=golang-dev
https://codereview.appspot.com/13010047

Committer: Adam Langley <agl@golang.org>