DescriptionFixes #1207045 extra whitespace in charm details
- When going from fullscreen editorial or search results to a charm details
the height was always matched to the editorial/results height. This causes
extra whitespace in the charm details layout.
- This was due to the indidicator spinner used for activity. It's using a
yui-hidden class when not showing to hide, but that causes it to still force
height.
- In the end, we can destroy the outdated content when we navigate to the
details. In fact, we should clean it up regardless. This adds code and a test
to verify that the .fullscreen() browser subapp function will clean older
editorial/search results views.
QA:
Go to /fullscreen, click on a charm. The height should be tighter to the end
of the charm details content. Compare against
comingsoon.jujucharms.com/fullscreen (and the same charm)
https://code.launchpad.net/~rharding/juju-gui/ie-whitespace-1207045/+merge/180366
(do not edit description out of merge proposal)
Patch Set 1 #Patch Set 2 : Fixes #1207045 extra whitespace in charm details #
MessagesTotal messages: 4
|