Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1283)

Issue 12997043: Fixes #1207045 extra whitespace in charm details

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by rharding
Modified:
10 years, 8 months ago
Reviewers:
mp+180366, j.c.sackett, matthew.scott
Visibility:
Public.

Description

Fixes #1207045 extra whitespace in charm details - When going from fullscreen editorial or search results to a charm details the height was always matched to the editorial/results height. This causes extra whitespace in the charm details layout. - This was due to the indidicator spinner used for activity. It's using a yui-hidden class when not showing to hide, but that causes it to still force height. - In the end, we can destroy the outdated content when we navigate to the details. In fact, we should clean it up regardless. This adds code and a test to verify that the .fullscreen() browser subapp function will clean older editorial/search results views. QA: Go to /fullscreen, click on a charm. The height should be tighter to the end of the charm details content. Compare against comingsoon.jujucharms.com/fullscreen (and the same charm) https://code.launchpad.net/~rharding/juju-gui/ie-whitespace-1207045/+merge/180366 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fixes #1207045 extra whitespace in charm details #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/subapps/browser/browser.js View 1 chunk +11 lines, -0 lines 0 comments Download
M test/test_browser_app.js View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rharding
Please take a look.
10 years, 8 months ago (2013-08-15 15:50:52 UTC) #1
matthew.scott
LGTM, thanks!
10 years, 8 months ago (2013-08-15 15:59:12 UTC) #2
j.c.sackett
LGTM, thanks!
10 years, 8 months ago (2013-08-15 15:59:39 UTC) #3
rharding
10 years, 8 months ago (2013-08-15 16:16:51 UTC) #4
*** Submitted:

Fixes #1207045 extra whitespace in charm details

- When going from fullscreen editorial or search results to a charm details
the height was always matched to the editorial/results height. This causes
extra whitespace in the charm details layout.
- This was due to the indidicator spinner used for activity. It's using a
yui-hidden class when not showing to hide, but that causes it to still force
height.
- In the end, we can destroy the outdated content when we navigate to the
details. In fact, we should clean it up regardless. This adds code and a test
to verify that the .fullscreen() browser subapp function will clean older
editorial/search results views.

QA:

Go to /fullscreen, click on a charm. The height should be tighter to the end
of the charm details content. Compare against
comingsoon.jujucharms.com/fullscreen (and the same charm)

R=matthew.scott, j.c.sackett
CC=
https://codereview.appspot.com/12997043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b