Issue 12991046: code review 12991046: net/http: support WriteString on the ResponseWriter

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12991046: code review 12991046: net/http: support WriteString on the ResponseWriter (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by bradfitz

Modified:
12 years ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

net/http: support WriteString on the ResponseWriter Fixes issue 5377

Patch Set 1 #

Patch Set 2 : diff -r d7ea9fa7b0cf https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d7ea9fa7b0cf https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8c13b98c57d1 https://go.googlecode.com/hg/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -3 lines)			Patch
	M	src/pkg/net/http/serve_test.go	View	1 2	1 chunk	+15 lines, -0 lines	0 comments	Download
	M	src/pkg/net/http/server.go	View	1	2 chunks	+16 lines, -3 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years ago (2013-08-20 05:53:27 UTC) #1

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=4e723952f542 *** net/http: support WriteString on the ResponseWriter Fixes issue 5377 R=golang-dev, ...

12 years ago (2013-08-20 05:57:00 UTC) #3

bradfitz

Even for minor performance things? This isn't an API change. On Aug 19, 2013 11:45 ...

12 years ago (2013-08-20 14:25:04 UTC) #5

If it's not an API change, then no.

Expand All Messages | Collapse All Messages