Issue 12987045: Fixing IE UI Bugs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12987045: Fixing IE UI Bugs

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by jeff.pihach

Modified:
10 years, 8 months ago

Reviewers:
rharding, matthew.scott, mp+181081

Visibility:
Public.

Description

Fixing IE UI Bugs IE10 puts a 'clear input' X when inputs are focused. This conflicts with our conflict ux story so this branch adds the CSS to hide those X's in the inspector. (1213270) Stops scale up dialogue from wrapping when the constraints are too wide (1213267) https://code.launchpad.net/~hatch/juju-gui/fix-ie-ux-bugs/+merge/181081 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fixing IE UI Bugs #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -6 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/templates/service-overview-constraints.handlebars	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	lib/views/juju-inspector.less	View	3 chunks	+10 lines, -5 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rharding

LGTM with the two questions. https://codereview.appspot.com/12987045/diff/1/lib/views/juju-inspector.less File lib/views/juju-inspector.less (left): https://codereview.appspot.com/12987045/diff/1/lib/views/juju-inspector.less#oldcode242 lib/views/juju-inspector.less:242: &:before { comment in ...

10 years, 8 months ago (2013-08-20 15:45:55 UTC) #2

jeff.pihach

Thanks for the reviews! https://codereview.appspot.com/12987045/diff/1/lib/views/juju-inspector.less File lib/views/juju-inspector.less (right): https://codereview.appspot.com/12987045/diff/1/lib/views/juju-inspector.less#newcode245 lib/views/juju-inspector.less:245: font-size: 11px; To match the ...

10 years, 8 months ago (2013-08-20 16:15:07 UTC) #4

jeff.pihach

10 years, 8 months ago (2013-08-20 16:21:47 UTC) #5

*** Submitted:

Fixing IE UI Bugs

IE10 puts a 'clear input' X when inputs are focused. This conflicts
with our conflict ux story so this branch adds the CSS to hide those
X's in the inspector. (1213270)

Stops scale up dialogue from wrapping when the constraints are too
wide (1213267)

R=rharding, matthew.scott
CC=
https://codereview.appspot.com/12987045

Expand All Messages | Collapse All Messages