Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(600)

Issue 129760044: code review 129760044: run.bash: run misc/cgo/testgodefs/test.bash (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by mdempsky
Modified:
11 years, 1 month ago
Reviewers:
gobot, iant
CC:
iant, golang-codereviews
Visibility:
Public.

Description

run.bash: run misc/cgo/testgodefs/test.bash misc/cgo/testgodefs was added by revision d1cf884a594f, but not add to run.bash.

Patch Set 1 #

Patch Set 2 : diff -r 58026885ac66 https://code.google.com/p/go #

Patch Set 3 : diff -r 58026885ac66 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/run.bash View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 5
mdempsky
Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 1 month ago (2014-08-12 07:45:17 UTC) #1
iant
LGTM Thanks! I see now that I've had this change in my local tree for ...
11 years, 1 month ago (2014-08-12 14:11:12 UTC) #2
iant
*** Submitted as https://code.google.com/p/go/source/detail?r=5b89b257e7e9 *** run.bash: run misc/cgo/testgodefs/test.bash misc/cgo/testgodefs was added by revision d1cf884a594f, but ...
11 years, 1 month ago (2014-08-12 14:14:01 UTC) #3
gobot
This CL appears to have broken the darwin-amd64-race-cheney builder. See http://build.golang.org/log/d518af7b33e06ead814bacbf5f8dc333c58e3734
11 years, 1 month ago (2014-08-12 14:29:12 UTC) #4
iant
11 years, 1 month ago (2014-08-12 14:31:49 UTC) #5
On Tue, Aug 12, 2014 at 7:29 AM,  <gobot@golang.org> wrote:
> This CL appears to have broken the darwin-amd64-race-cheney builder.
> See http://build.golang.org/log/d518af7b33e06ead814bacbf5f8dc333c58e3734
>
> https://codereview.appspot.com/129760044/

I doubt it.

SIGQUIT: quit
PC=0x30f43

goroutine 2 [syscall]:
runtime.notetsleepg(0xc208019f70, 0xdf8475800)
/usr/local/go/src/pkg/runtime/lock_sema.c:263 +0x86 fp=0xc208019f48
sp=0xc208019f18
runtime.MHeap_Scavenger()
/usr/local/go/src/pkg/runtime/mheap.c:664 +0x99 fp=0xc208019fa8 sp=0xc208019f48
runtime.goexit()
/usr/local/go/src/pkg/runtime/proc.c:1475 fp=0xc208019fb0 sp=0xc208019fa8
created by runtime.main
/usr/local/go/src/pkg/runtime/proc.c:222

goroutine 1 [chan receive, 9 minutes]:
testing.RunTests(0x20b478, 0x2c1640, 0x3, 0x3, 0xc8ab01)
/usr/local/go/src/pkg/testing/testing.go:510 +0xbb0
testing.Main(0x20b478, 0x2c1640, 0x3, 0x3, 0x2c9900, 0x0, 0x0,
0x2c9900, 0x0, 0x0)
/usr/local/go/src/pkg/testing/testing.go:440 +0xa3
main.main()
runtime/race/_test/_testmain.go:51 +0xdd

goroutine 4 [finalizer wait, 9 minutes]:
runtime.park(0x1e970, 0x2c6530, 0x2c5187)
/usr/local/go/src/pkg/runtime/proc.c:1406 +0x97
runtime.parkunlock(0x2c6530, 0x2c5187)
/usr/local/go/src/pkg/runtime/proc.c:1422 +0x3b
runfinq()
/usr/local/go/src/pkg/runtime/mgc0.c:1645 +0xcf
runtime.goexit()
/usr/local/go/src/pkg/runtime/proc.c:1475

goroutine 10 [syscall, 9 minutes]:
syscall.Syscall6(0x7, 0x7ce1, 0xc208037814, 0x0, 0xc20804e090, 0x0,
0x0, 0xc208013fa0, 0x1fa23, 0xc2080282e0)
/usr/local/go/src/pkg/syscall/asm_darwin_amd64.s:44 +0x5
syscall.wait4(0x7ce1, 0xc208037814, 0x0, 0xc20804e090, 0x1b1060, 0x0, 0x0)
/usr/local/go/src/pkg/syscall/zsyscall_darwin_amd64.go:32 +0x8b
syscall.Wait4(0x7ce1, 0xc20803785c, 0x0, 0xc20804e090, 0x0, 0x0, 0x0)
/usr/local/go/src/pkg/syscall/syscall_bsd.go:162 +0x72
os.(*Process).wait(0xc20800a040, 0x0, 0x0, 0x0)
/usr/local/go/src/pkg/os/exec_unix.go:22 +0x15c
os.(*Process).Wait(0xc20800a040, 0xc208058000, 0x0, 0x0)
/usr/local/go/src/pkg/os/doc.go:45 +0x47
os/exec.(*Cmd).Wait(0xc208058140, 0x0, 0x0)
/usr/local/go/src/pkg/os/exec/exec.go:357 +0x2b0
os/exec.(*Cmd).Run(0xc208058140, 0x0, 0x0)
/usr/local/go/src/pkg/os/exec/exec.go:239 +0x83
os/exec.(*Cmd).CombinedOutput(0xc208058140, 0x0, 0x0, 0x0, 0x0, 0x0)
/usr/local/go/src/pkg/os/exec/exec.go:401 +0x3d0
runtime/race_test.runTests(0x0, 0x0, 0x0, 0x0, 0x0)
/Users/builder/workspace/darwin-amd64-race-cheney-5b89b257e7e9/go/src/pkg/runtime/race/race_test.go:156
+0x805
runtime/race_test.TestRace(0xc20804e120)
/Users/builder/workspace/darwin-amd64-race-cheney-5b89b257e7e9/go/src/pkg/runtime/race/race_test.go:43
+0x3a
testing.tRunner(0xc20804e120, 0x2c1658)
/usr/local/go/src/pkg/testing/testing.go:427 +0x10c
created by testing.RunTests
/usr/local/go/src/pkg/testing/testing.go:509 +0xb3e

goroutine 11 [syscall, 6 minutes]:
syscall.Syscall(0x3, 0x6, 0xc2080dc22b, 0x11bd5, 0x2c9b20, 0x22ae7, 0x2c9b20)
/usr/local/go/src/pkg/syscall/asm_darwin_amd64.s:20 +0x5
syscall.read(0x6, 0xc2080dc22b, 0x11bd5, 0x11bd5, 0xaab, 0x0, 0x0)
/usr/local/go/src/pkg/syscall/zsyscall_darwin_amd64.go:952 +0x83
syscall.Read(0x6, 0xc2080dc22b, 0x11bd5, 0x11bd5, 0xaab, 0x0, 0x0)
/usr/local/go/src/pkg/syscall/syscall_unix.go:136 +0x6a
os.(*File).read(0xc208030078, 0xc2080dc22b, 0x11bd5, 0x11bd5, 0xaab, 0x0, 0x0)
/usr/local/go/src/pkg/os/file_unix.go:190 +0xc9
os.(*File).Read(0xc208030078, 0xc2080dc22b, 0x11bd5, 0x11bd5, 0xaab, 0x0, 0x0)
/usr/local/go/src/pkg/os/file.go:95 +0xcb
bytes.(*Buffer).ReadFrom(0xc20805a070, 0xc8ace8, 0xc208030078,
0x2e22b, 0x0, 0x0)
/usr/local/go/src/pkg/bytes/buffer.go:169 +0x41c
io.Copy(0xc8ac98, 0xc20805a070, 0xc8ace8, 0xc208030078, 0x0, 0x0, 0x0)
/usr/local/go/src/pkg/io/io.go:349 +0x161
os/exec.funcĀ·003(0x0, 0x0)
/usr/local/go/src/pkg/os/exec/exec.go:214 +0xbc
os/exec.funcĀ·004(0xc20800a920)
/usr/local/go/src/pkg/os/exec/exec.go:321 +0x3a
created by os/exec.(*Cmd).Start
/usr/local/go/src/pkg/os/exec/exec.go:322 +0x10bc

rax     0xe
rbx     0x0
rcx     0xc208019ec0
rdx     0x0
rdi     0x1403
rsi     0x3c
rbp     0xc208019ee4
rsp     0xc208019ec0
r8      0x7fc75c8
r9      0x1
r10     0x53c69bf60
r11     0x216
r12     0x0
r13     0xa4e0b5201fb98
r14     0x1389b378d02c4400
r15     0x20b718
rip     0x30f43
rflags  0x216
cs      0x7
fs      0x20000000
gs      0x20000
*** Test killed with quit: ran too long (10m0s).
FAIL runtime/race 600.024s
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b