Issue 12969043: code review 12969043: time: expand acceptance of time zones when parsing

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12969043: code review 12969043: time: expand acceptance of time zones when parsing (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by r

Modified:
11 years, 9 months ago

Reviewers:
adg

CC:
golang-dev, adg

Visibility:
Public.

Description

time: expand acceptance of time zones when parsing I tried to make it absolutely correct but there are too many conflicting definitions for the official list of time zones. Since when we're parsing we know when to expect a time zone and we know what they look like if not exactly what the definitive set is, we compromise. We accept any three-character sequence of upper case letters, possibly followed by a capital T (all four-letter zones end in T). There is one crazy special case (ChST) and the possibility of a signed hour offset for GMT. Fixes issue 3790 I hope forever, but I doubt that very much.

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r 60eb79a2cd0f https://code.google.com/p/go/ #

Patch Set 3 : diff -r 5c0a32c41738 https://code.google.com/p/go/ #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -14 lines)			Patch
	M	src/pkg/time/format.go	View	1 2	1 chunk	+23 lines, -14 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 9 months ago (2013-08-15 01:13:08 UTC) #1

adg

LGTM https://codereview.appspot.com/12969043/diff/1/src/pkg/time/format.go File src/pkg/time/format.go (right): https://codereview.appspot.com/12969043/diff/1/src/pkg/time/format.go#newcode1046 src/pkg/time/format.go:1046: // There must be three lower-case letters. s/lower/upper/

11 years, 9 months ago (2013-08-15 01:28:22 UTC) #2

Hello golang-dev@googlegroups.com, adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 9 months ago (2013-08-15 01:33:16 UTC) #3

11 years, 9 months ago (2013-08-15 06:43:00 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=e99621daceb3 ***

time: expand acceptance of time zones when parsing
I tried to make it absolutely correct but there are too many
conflicting definitions for the official list of time zones.
Since when we're parsing we know when to expect
a time zone and we know what they look like if not exactly
what the definitive set is, we compromise. We accept any
three-character sequence of upper case letters, possibly
followed by a capital T (all four-letter zones end in T).

There is one crazy special case (ChST) and the possibility
of a signed hour offset for GMT.

Fixes issue 3790
I hope forever, but I doubt that very much.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/12969043

Expand All Messages | Collapse All Messages