Normalizing the getConstraints code

Normalizing the getConstraints code

In order to allow us to share constraints code across
the three locations it needs to be used it needed to
be normalized. This is the first step towards the following
ghost constraints and upgrade ux constraints branches.

https://code.launchpad.net/~hatch/juju-gui/normalize-constraints/+merge/180920

(do not edit description out of merge proposal)

[jeff.pihach, 2013-08-19 17:54:24]

Please take a look.

[bac, 2013-08-19 19:50:43]

LGTM and QA.

As an aside, the units display on constraints is very cluttered as it blends
with the name of the next field.  I think

CPU (GHz)
[ text input here]

would be much more readable.

https://codereview.appspot.com/12956045/diff/1/app/views/utils.js
File app/views/utils.js (right):

https://codereview.appspot.com/12956045/diff/1/app/views/utils.js#newcode520
app/views/utils.js:520: @param {Array} readOnlyConstraints Constraint keys to be
excluded from
delete me and my friend

https://codereview.appspot.com/12956045/diff/1/app/views/utils.js#newcode535
app/views/utils.js:535: cpu: {title: 'CPU', unit: 'Ghz'},
GHz please

https://codereview.appspot.com/12956045/diff/1/app/views/utils.js#newcode537
app/views/utils.js:537: 'cpu-power': {title: 'CPU Power', unit: 'Ghz'},
here too

https://codereview.appspot.com/12956045/diff/1/app/views/viewlets/service-con...
File app/views/viewlets/service-constraints.js (left):

https://codereview.appspot.com/12956045/diff/1/app/views/viewlets/service-con...
app/views/viewlets/service-constraints.js:40: cpu: {title: 'CPU', unit: 'Ghz'},
Yeah, it wasn't your doing but still wrong.

https://codereview.appspot.com/12956045/diff/1/test/test_inspector_constraint...
File test/test_inspector_constraints.js (right):

https://codereview.appspot.com/12956045/diff/1/test/test_inspector_constraint...
test/test_inspector_constraints.js:133: cpu: {title: 'CPU', unit: 'Ghz'},
This'll now break.

[jeff.pihach, 2013-08-19 19:54:20]

Thanks for the review and QA!
Changes has been made. The UI is definitely not ideal but this branch is setting
up the changes for the follow-ups.

https://codereview.appspot.com/12956045/diff/1/app/views/utils.js
File app/views/utils.js (right):

https://codereview.appspot.com/12956045/diff/1/app/views/utils.js#newcode520
app/views/utils.js:520: @param {Array} readOnlyConstraints Constraint keys to be
excluded from
On 2013/08/19 19:50:44, bac wrote:
> delete me and my friend

Done.

https://codereview.appspot.com/12956045/diff/1/app/views/utils.js#newcode535
app/views/utils.js:535: cpu: {title: 'CPU', unit: 'Ghz'},
On 2013/08/19 19:50:44, bac wrote:
> GHz please

Done.

https://codereview.appspot.com/12956045/diff/1/app/views/utils.js#newcode537
app/views/utils.js:537: 'cpu-power': {title: 'CPU Power', unit: 'Ghz'},
On 2013/08/19 19:50:44, bac wrote:
> here too

Done.

https://codereview.appspot.com/12956045/diff/1/test/test_inspector_constraint...
File test/test_inspector_constraints.js (right):

https://codereview.appspot.com/12956045/diff/1/test/test_inspector_constraint...
test/test_inspector_constraints.js:133: cpu: {title: 'CPU', unit: 'Ghz'},
On 2013/08/19 19:50:44, bac wrote:
> This'll now break. 

Done.

[jeff.pihach, 2013-08-19 20:05:22]

Please take a look.

[benji, 2013-08-19 20:11:02]

This LGTM, aside from one test that I'd really like to see un-crippled.

https://codereview.appspot.com/12956045/diff/1/test/test_inspector_constraint...
File test/test_inspector_constraints.js (right):

https://codereview.appspot.com/12956045/diff/1/test/test_inspector_constraint...
test/test_inspector_constraints.js:130: // mock - copied from utils.js
getConstraints
Without the connection to the real data structure this test doesn't help much. 
We need to DRY this up by finding a way to re-connect it to the code it tests.

[jeff.pihach, 2013-08-19 20:33:48]

Thanks for the reviews!

https://codereview.appspot.com/12956045/diff/1/test/test_inspector_constraint...
File test/test_inspector_constraints.js (right):

https://codereview.appspot.com/12956045/diff/1/test/test_inspector_constraint...
test/test_inspector_constraints.js:130: // mock - copied from utils.js
getConstraints
Replaced the private variables with ones hanging off of utils and changed the
tests and sources.

[jeff.pihach, 2013-08-19 21:17:58]

*** Submitted:

Normalizing the getConstraints code

In order to allow us to share constraints code across
the three locations it needs to be used it needed to
be normalized. This is the first step towards the following
ghost constraints and upgrade ux constraints branches.

R=bac, benji
CC=
https://codereview.appspot.com/12956045