code review 129550043: cmd/gc: disallow call of *T method using **T variable

cmd/gc: disallow call of *T method using **T variable

This brings cmd/gc in line with the spec on this question.
It might break existing code, but that code was not conformant
with the spec.

Credit to Rémy for finding the broken code.

Fixes issue 6366.

[rsc, 2014-08-25 01:00:34]

Hello golang-codereviews@googlegroups.com (cc: adonovan, gri),

I'd like you to review this change to
https://code.google.com/p/go/

[r, 2014-08-26 17:51:16]

LGTM

[rsc, 2014-10-21 02:04:20]

*** Submitted as https://code.google.com/p/go/source/detail?r=440c1cc9f5d6 ***

cmd/gc: disallow call of *T method using **T variable

This brings cmd/gc in line with the spec on this question.
It might break existing code, but that code was not conformant
with the spec.

Credit to Rémy for finding the broken code.

Fixes issue 6366.

LGTM=r
R=golang-codereviews, r
CC=adonovan, golang-codereviews, gri
https://codereview.appspot.com/129550043

[gobot, 2014-10-21 02:52:44]

This changed caused perf changes on linux-amd64-perf:


build-1                   old          new      delta
build-cputime     10220638000  10124632000      -0.94

build-2                   old          new      delta
build-cputime     10280641000  10188636000      -0.89

build-8                   old          new      delta
build-cputime     10420651000  10348646000      -0.69

http://build.golang.org/perfdetail?commit=440c1cc9f5d6c5a00b038889476a5e2f6bf...



—gobot