Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

Issue 129500043: code review 129500043: go.sys/unix: delete Fork and Exec etc. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by r
Modified:
10 years, 6 months ago
Reviewers:
dave
CC:
rsc, dave_cheney.net, josharian, golang-codereviews
Visibility:
Public.

Description

go.sys/unix: delete Fork and Exec etc. These are being deleted from go.sys because in general they can only be implemented in close coordination with the runtime.

Patch Set 1 #

Patch Set 2 : diff -r f9dd92b9d882ea97828a1218ea3708a738db317b https://code.google.com/p/go.sys #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1005 lines) Patch
R unix/exec_bsd.go View 1 chunk +0 lines, -248 lines 0 comments Download
R unix/exec_linux.go View 1 chunk +0 lines, -263 lines 0 comments Download
R unix/exec_solaris.go View 1 chunk +0 lines, -244 lines 0 comments Download
R unix/exec_unix.go View 1 chunk +0 lines, -250 lines 0 comments Download
M unix/syscall_unix.go View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 4
r
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.sys
10 years, 6 months ago (2014-08-21 21:46:44 UTC) #1
dave_cheney.net
LGTM. Please fix teh typo in the description. On 22 Aug 2014 07:46, <r@golang.org> wrote: ...
10 years, 6 months ago (2014-08-21 22:17:15 UTC) #2
josharian
> LGTM. Please fix teh typo in the description. Maybe it's not a typo: http://en.wikipedia.org/wiki/Teh. ...
10 years, 6 months ago (2014-08-21 22:18:59 UTC) #3
r
10 years, 6 months ago (2014-08-21 23:14:53 UTC) #4
*** Submitted as
https://code.google.com/p/go/source/detail?r=ede06fd7a821&repo=sys ***

go.sys/unix: delete Fork and Exec etc.
These are being deleted from go.sys because in general they can
only be implemented in close coordination with the runtime.

LGTM=dave
R=rsc, dave, josharian
CC=golang-codereviews
https://codereview.appspot.com/129500043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b