Add generic GCC >= 4.7 support for atomic operations

Add generic GCC >= 4.7 support for atomic operations

[xiaofeng, 2014-08-21 22:21:35]

Thanks for making the change. Just some nitpickings. See below.

https://codereview.appspot.com/129490043/diff/1/src/google/protobuf/stubs/ato...
File src/google/protobuf/stubs/atomicops_internals_generic_gcc.h (right):

https://codereview.appspot.com/129490043/diff/1/src/google/protobuf/stubs/ato...
src/google/protobuf/stubs/atomicops_internals_generic_gcc.h:1: // Protocol
Buffers - Google's data interchange format
Can you remove line 1 & 3?  They give me the impression that Protocol Buffers is
copyrighted by Red Hat Inc, which is misleading. Also can you point me to the
original source of this header file (in Red Hat's source repository)?

https://codereview.appspot.com/129490043/diff/1/src/google/protobuf/stubs/ato...
src/google/protobuf/stubs/atomicops_internals_generic_gcc.h:75:
__ATOMIC_RELEASE, __ATOMIC_ACQUIRE);
Please fix the alignment.

https://codereview.appspot.com/129490043/diff/1/src/google/protobuf/stubs/ato...
src/google/protobuf/stubs/atomicops_internals_generic_gcc.h:129:
__ATOMIC_RELAXED, __ATOMIC_RELAXED);
dito

https://codereview.appspot.com/129490043/diff/1/src/google/protobuf/stubs/pla...
File src/google/protobuf/stubs/platform_macros.h (right):

https://codereview.appspot.com/129490043/diff/1/src/google/protobuf/stubs/pla...
src/google/protobuf/stubs/platform_macros.h:68: #elif defined(__GNUC__) &&
(((__GNUC__ == 4) && (__GNUC_MINOR__ >= 7)) || (__GNUC__ > 4))
Wrap the line to be within the 80 characters column limit.

[robert.edmonds, 2014-08-22 18:01:27]

https://codereview.appspot.com/129490043/diff/1/src/google/protobuf/stubs/ato...
File src/google/protobuf/stubs/atomicops_internals_generic_gcc.h (right):

https://codereview.appspot.com/129490043/diff/1/src/google/protobuf/stubs/ato...
src/google/protobuf/stubs/atomicops_internals_generic_gcc.h:1: // Protocol
Buffers - Google's data interchange format
On 2014/08/21 22:21:35, xiaofeng wrote:
> Can you remove line 1 & 3?  They give me the impression that Protocol Buffers
is
> copyrighted by Red Hat Inc, which is misleading. Also can you point me to the
> original source of this header file (in Red Hat's source repository)? 

Here is the commit in Red Hat's repository.

http://pkgs.fedoraproject.org/cgit/protobuf.git/tree/0001-Add-generic-GCC-sup...

https://codereview.appspot.com/129490043/diff/1/src/google/protobuf/stubs/ato...
src/google/protobuf/stubs/atomicops_internals_generic_gcc.h:1: // Protocol
Buffers - Google's data interchange format
On 2014/08/21 22:21:35, xiaofeng wrote:
> Can you remove line 1 & 3?  They give me the impression that Protocol Buffers
is
> copyrighted by Red Hat Inc, which is misleading. Also can you point me to the
> original source of this header file (in Red Hat's source repository)? 

Acknowledged.

https://codereview.appspot.com/129490043/diff/1/src/google/protobuf/stubs/ato...
src/google/protobuf/stubs/atomicops_internals_generic_gcc.h:75:
__ATOMIC_RELEASE, __ATOMIC_ACQUIRE);
On 2014/08/21 22:21:35, xiaofeng wrote:
> Please fix the alignment.

Acknowledged.

https://codereview.appspot.com/129490043/diff/1/src/google/protobuf/stubs/ato...
src/google/protobuf/stubs/atomicops_internals_generic_gcc.h:129:
__ATOMIC_RELAXED, __ATOMIC_RELAXED);
On 2014/08/21 22:21:35, xiaofeng wrote:
> dito

Acknowledged.

https://codereview.appspot.com/129490043/diff/1/src/google/protobuf/stubs/pla...
File src/google/protobuf/stubs/platform_macros.h (right):

https://codereview.appspot.com/129490043/diff/1/src/google/protobuf/stubs/pla...
src/google/protobuf/stubs/platform_macros.h:68: #elif defined(__GNUC__) &&
(((__GNUC__ == 4) && (__GNUC_MINOR__ >= 7)) || (__GNUC__ > 4))
On 2014/08/21 22:21:35, xiaofeng wrote:
> Wrap the line to be within the 80 characters column limit.

Acknowledged.

[robert.edmonds, 2014-08-22 18:05:18]

https://codereview.appspot.com/129490043/diff/1/src/google/protobuf/stubs/ato...
File src/google/protobuf/stubs/atomicops_internals_generic_gcc.h (right):

https://codereview.appspot.com/129490043/diff/1/src/google/protobuf/stubs/ato...
src/google/protobuf/stubs/atomicops_internals_generic_gcc.h:1: // Protocol
Buffers - Google's data interchange format
On 2014/08/21 22:21:35, xiaofeng wrote:
> Can you remove line 1 & 3?  They give me the impression that Protocol Buffers
is
> copyrighted by Red Hat Inc, which is misleading. Also can you point me to the
> original source of this header file (in Red Hat's source repository)? 

Done.

https://codereview.appspot.com/129490043/diff/1/src/google/protobuf/stubs/ato...
src/google/protobuf/stubs/atomicops_internals_generic_gcc.h:75:
__ATOMIC_RELEASE, __ATOMIC_ACQUIRE);
On 2014/08/21 22:21:35, xiaofeng wrote:
> Please fix the alignment.

Done.

https://codereview.appspot.com/129490043/diff/1/src/google/protobuf/stubs/ato...
src/google/protobuf/stubs/atomicops_internals_generic_gcc.h:129:
__ATOMIC_RELAXED, __ATOMIC_RELAXED);
On 2014/08/21 22:21:35, xiaofeng wrote:
> dito

Done.

https://codereview.appspot.com/129490043/diff/1/src/google/protobuf/stubs/pla...
File src/google/protobuf/stubs/platform_macros.h (right):

https://codereview.appspot.com/129490043/diff/1/src/google/protobuf/stubs/pla...
src/google/protobuf/stubs/platform_macros.h:68: #elif defined(__GNUC__) &&
(((__GNUC__ == 4) && (__GNUC_MINOR__ >= 7)) || (__GNUC__ > 4))
On 2014/08/21 22:21:35, xiaofeng wrote:
> Wrap the line to be within the 80 characters column limit.

Done.

[xiaofeng, 2014-08-22 18:25:03]

LGTM

[xiaofeng, 2014-08-22 18:25:35]

Jie, can you help commit this change?


On Fri, Aug 22, 2014 at 11:25 AM, <xiaofeng@google.com> wrote:

> LGTM
>
> https://codereview.appspot.com/129490043/
>

[jieluo, 2014-08-22 20:24:38]

On 2014/08/22 18:25:35, xiaofeng wrote:
> Jie, can you help commit this change?
> 
> 
> On Fri, Aug 22, 2014 at 11:25 AM, <mailto:xiaofeng@google.com> wrote:
> 
> > LGTM
> >
> > https://codereview.appspot.com/129490043/
> >

Done. Thanks for the patch
https://code.google.com/p/protobuf/source/detail?r=575