Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(773)

Issue 12943045: juju: juju.NewAPIClientFromName

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by jameinel
Modified:
10 years, 8 months ago
Reviewers:
mp+182098, rog
Visibility:
Public.

Description

juju: juju.NewAPIClientFromName Rather than exposing APIConn and its associated Environ object, William asked if we could expose something smaller. We really don't want CLI code to be directly needing provider credentials, etc. The only thing the current caller did with APIConn was ask for the conn.State.Client() anyway. This should give us more focused thoughts that the CLI only thinks about stuff via the API calls it makes, as the only thing it *has* is a thing to make API calls. https://code.launchpad.net/~jameinel/juju-core/new-api-conn/+merge/182098 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : juju: juju.NewAPIClientFromName #

Patch Set 3 : juju: juju.NewAPIClientFromName #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -22 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/addunit.go View 1 chunk +3 lines, -4 lines 0 comments Download
M juju/api.go View 1 2 1 chunk +9 lines, -4 lines 0 comments Download
M juju/apiconn_test.go View 1 2 1 chunk +35 lines, -10 lines 0 comments Download
M rpc/rpc_test.go View 1 2 2 chunks +13 lines, -2 lines 0 comments Download
M rpc/server.go View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M state/api/client.go View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
A state/api/client_test.go View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
A state/api/state_test.go View 1 2 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 4
jameinel
Please take a look.
10 years, 8 months ago (2013-08-26 13:13:10 UTC) #1
jameinel
Please take a look.
10 years, 8 months ago (2013-08-26 13:17:09 UTC) #2
rog
On 2013/08/26 13:17:09, jameinel wrote: > Please take a look. LGTM modulo comments expressed in ...
10 years, 8 months ago (2013-08-27 08:51:20 UTC) #3
jameinel
10 years, 8 months ago (2013-08-28 07:18:05 UTC) #4
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b