Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(631)

Issue 12939043: code review 12939043: net: make TCPStress test shorter (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by dvyukov
Modified:
11 years, 10 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

net: make TCPStress test shorter It timeouts on freebsd builders: http://build.golang.org/log/3d8169e13bff912bebf6fd3c54b34ad2d29a7221 but there are always runnable goroutines, which suggests that it's slowly progressing.

Patch Set 1 #

Patch Set 2 : diff -r a254f0f80b6f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r a254f0f80b6f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 0c3151a90023 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/pkg/net/tcp_test.go View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
11 years, 10 months ago (2013-08-14 17:46:20 UTC) #1
bradfitz
LGTM On Wed, Aug 14, 2013 at 10:46 AM, <dvyukov@google.com> wrote: > Reviewers: golang-dev1, > ...
11 years, 10 months ago (2013-08-14 17:48:51 UTC) #2
dvyukov
11 years, 10 months ago (2013-08-14 17:53:53 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=4768414e92d8 ***

net: make TCPStress test shorter
It timeouts on freebsd builders:
http://build.golang.org/log/3d8169e13bff912bebf6fd3c54b34ad2d29a7221
but there are always runnable goroutines,
which suggests that it's slowly progressing.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12939043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b