Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(748)

Issue 12936046: code review 12936046: go.tools/cmd/vet: check for recursive stringers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by adg
Modified:
4 years, 3 months ago
Reviewers:
r
CC:
r, golang-dev
Visibility:
Public.

Description

go.tools/cmd/vet: check for recursive stringers Fixes issue 6129.

Patch Set 1 #

Patch Set 2 : diff -r 40ea8f657df4 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 40ea8f657df4 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 40ea8f657df4 https://code.google.com/p/go.tools #

Patch Set 5 : diff -r 40ea8f657df4 https://code.google.com/p/go.tools #

Patch Set 6 : diff -r 40ea8f657df4 https://code.google.com/p/go.tools #

Total comments: 1

Patch Set 7 : diff -r 7cdd043fad2b https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -0 lines) Patch
M cmd/vet/main.go View 1 2 3 4 2 chunks +27 lines, -0 lines 0 comments Download
M cmd/vet/print.go View 1 2 3 4 5 6 2 chunks +34 lines, -0 lines 0 comments Download
M cmd/vet/testdata/print.go View 1 2 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5
adg
Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
4 years, 3 months ago (2013-08-20 23:51:12 UTC) #1
r
please separate the buildability fixes into a separate CL
4 years, 3 months ago (2013-08-21 00:00:29 UTC) #2
adg
Hello r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
4 years, 3 months ago (2013-08-21 00:08:02 UTC) #3
r
LGTM https://codereview.appspot.com/12936046/diff/14001/cmd/vet/print.go File cmd/vet/print.go (right): https://codereview.appspot.com/12936046/diff/14001/cmd/vet/print.go#newcode414 cmd/vet/print.go:414: return obj == f.lastStringerReceiver // We compare the ...
4 years, 3 months ago (2013-08-21 01:05:46 UTC) #4
adg
4 years, 3 months ago (2013-08-21 01:08:00 UTC) #5
*** Submitted as
https://code.google.com/p/go/source/detail?r=4811a56849fc&repo=tools ***

go.tools/cmd/vet: check for recursive stringers

Fixes issue 6129.

R=r
CC=golang-dev
https://codereview.appspot.com/12936046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4