code review 12927045: runtime: fix goroutine stack accounting

runtime: fix goroutine stack accounting
Fixes issue 6166.
Fixes issue 6168.

[dvyukov, 2013-08-16 16:36:35]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[bradfitz, 2013-08-16 16:38:54]

LGTM

hah



On Fri, Aug 16, 2013 at 9:36 AM, <dvyukov@google.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
>
https://dvyukov%40google.com@**code.google.com/p/go/<http://40google.com@code...
>
>
> Description:
> runtime: fix goroutine stack accounting
> Fixes issue 6161.
> Fixes issue 6166.
> Fixes issue 6168.
>
> Please review this at
https://codereview.appspot.**com/12927045/<https://codereview.appspot.com/129...
>
> Affected files:
>   M src/pkg/runtime/proc.c
>
>
> Index: src/pkg/runtime/proc.c
> ==============================**==============================**=======
> --- a/src/pkg/runtime/proc.c
> +++ b/src/pkg/runtime/proc.c
> @@ -1676,7 +1676,7 @@
>                         stk = g->param;
>                         g->param = nil;
>                 }
> -               g->stacksize = StackSystem + stacksize;
> +               newg->stacksize = StackSystem + stacksize;
>                 newg->stack0 = (uintptr)stk;
>                 newg->stackguard = (uintptr)stk + StackGuard;
>                 newg->stackguard0 = newg->stackguard;
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[remyoudompheng, 2013-08-16 16:57:50]

How does it fix issue 6161? Nilptr2.go really wants 250MB of stack and
that's the limit on 32-bit arches.


2013/8/16, dvyukov@google.com <dvyukov@google.com>:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://dvyukov%40google.com@code.google.com/p/go/
>
>
> Description:
> runtime: fix goroutine stack accounting
> Fixes issue 6161.
> Fixes issue 6166.
> Fixes issue 6168.
>
> Please review this at https://codereview.appspot.com/12927045/
>
> Affected files:
>    M src/pkg/runtime/proc.c
>
>
> Index: src/pkg/runtime/proc.c
> ===================================================================
> --- a/src/pkg/runtime/proc.c
> +++ b/src/pkg/runtime/proc.c
> @@ -1676,7 +1676,7 @@
>   			stk = g->param;
>   			g->param = nil;
>   		}
> -		g->stacksize = StackSystem + stacksize;
> +		newg->stacksize = StackSystem + stacksize;
>   		newg->stack0 = (uintptr)stk;
>   		newg->stackguard = (uintptr)stk + StackGuard;
>   		newg->stackguard0 = newg->stackguard;
>
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[dvyukov, 2013-08-16 17:03:53]

removed 6161


On Fri, Aug 16, 2013 at 8:57 PM, Rémy Oudompheng
<remyoudompheng@gmail.com>wrote:

> How does it fix issue 6161? Nilptr2.go really wants 250MB of stack and
> that's the limit on 32-bit arches.
>
>
> 2013/8/16, dvyukov@google.com <dvyukov@google.com>:
> > Reviewers: golang-dev1,
> >
> > Message:
> > Hello golang-dev@googlegroups.com,
> >
> > I'd like you to review this change to
> > https://dvyukov%40google.com@code.google.com/p/go/
> >
> >
> > Description:
> > runtime: fix goroutine stack accounting
> > Fixes issue 6161.
> > Fixes issue 6166.
> > Fixes issue 6168.
> >
> > Please review this at https://codereview.appspot.com/12927045/
> >
> > Affected files:
> >    M src/pkg/runtime/proc.c
> >
> >
> > Index: src/pkg/runtime/proc.c
> > ===================================================================
> > --- a/src/pkg/runtime/proc.c
> > +++ b/src/pkg/runtime/proc.c
> > @@ -1676,7 +1676,7 @@
> >                       stk = g->param;
> >                       g->param = nil;
> >               }
> > -             g->stacksize = StackSystem + stacksize;
> > +             newg->stacksize = StackSystem + stacksize;
> >               newg->stack0 = (uintptr)stk;
> >               newg->stackguard = (uintptr)stk + StackGuard;
> >               newg->stackguard0 = newg->stackguard;
> >
> >
> > --
> >
> > ---
> > You received this message because you are subscribed to the Google Groups
> > "golang-dev" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to golang-dev+unsubscribe@googlegroups.com.
> > For more options, visit https://groups.google.com/groups/opt_out.
> >
>

[dvyukov, 2013-08-16 17:04:10]

*** Submitted as https://code.google.com/p/go/source/detail?r=740de86d6b70 ***

runtime: fix goroutine stack accounting
Fixes issue 6166.
Fixes issue 6168.

R=golang-dev, bradfitz, remyoudompheng
CC=golang-dev
https://codereview.appspot.com/12927045