Issue 12927043: Multipart mail support (plain and html) in sendmail()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12927043: Multipart mail support (plain and html) in sendmail() (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by ana.balica

Modified:
10 years, 8 months ago

Reviewers:
waldi

Visibility:
Public.

More Reviews

Description

The function doesn't break previous usages of sending plain text mail. In case we need to send a multipart/alternative mail with plain and html contents, we set the argument html= to html data.

Patch Set 2 : Check 'if html' - assume it can't be an empty string #

Patch Set 3 : Remove the replacement to CRLF #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -6 lines)			Patch
	M	MoinMoin/mail/sendmail.py	View	1 2	4 chunks	+20 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

waldi

https://codereview.appspot.com/12927043/diff/1/MoinMoin/mail/sendmail.py File MoinMoin/mail/sendmail.py (right): https://codereview.appspot.com/12927043/diff/1/MoinMoin/mail/sendmail.py#newcode114 MoinMoin/mail/sendmail.py:114: text_msg = Message() I'm not sure if Message and ...

10 years, 9 months ago (2013-08-14 13:00:00 UTC) #1

ana.balica

10 years, 9 months ago (2013-08-14 13:24:15 UTC) #2

ana.balica

10 years, 9 months ago (2013-08-14 13:39:10 UTC) #3

https://codereview.appspot.com/12927043/diff/1/MoinMoin/mail/sendmail.py
File MoinMoin/mail/sendmail.py (right):

https://codereview.appspot.com/12927043/diff/1/MoinMoin/mail/sendmail.py#newc...
MoinMoin/mail/sendmail.py:131: html = html.encode(CHARSET)
On 2013/08/14 13:00:00, waldi wrote:
> Please change this to always utf-8 in a different change-set.

I think i am missing something.
Are you suggesting to remove this line from the cr and then commit
html.encode('utf-8') to a different change-set?

Expand All Messages | Collapse All Messages