Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(752)

Issue 12923043: code review 12923043: cmd/go: fix detached heads that are remnants of bad git... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by dsymonds
Modified:
4 years, 3 months ago
Reviewers:
adg, rsc
CC:
adg, golang-dev
Visibility:
Public.

Description

cmd/go: fix detached heads that are remnants of bad git clones. Fixes issue 6042.

Patch Set 1 #

Patch Set 2 : diff -r 96fefaa02ae3 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r fa4c62bd1d41 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r fa4c62bd1d41 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 5cd71559a858 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M src/cmd/go/vcs.go View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 6
dsymonds
Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
4 years, 3 months ago (2013-08-14 06:44:24 UTC) #1
adg
please add a TODO to remove this after go1.2 is released
4 years, 3 months ago (2013-08-14 06:58:42 UTC) #2
dsymonds
On 14 August 2013 16:58, <adg@golang.org> wrote: > please add a TODO to remove this ...
4 years, 3 months ago (2013-08-14 07:00:16 UTC) #3
adg
LGTM
4 years, 3 months ago (2013-08-14 07:03:21 UTC) #4
dsymonds
*** Submitted as https://code.google.com/p/go/source/detail?r=3ec140949606 *** cmd/go: fix detached heads that are remnants of bad git ...
4 years, 3 months ago (2013-08-14 23:44:30 UTC) #5
rsc
4 years, 3 months ago (2013-08-14 23:45:34 UTC) #6
this cl sounds like the plot of a bad zombie movie
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4