Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(285)

Issue 12916043: code review 12916043: cmd/go: fix bad error message in coverage for package w... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by r
Modified:
10 years, 7 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

cmd/go: fix bad error message in coverage for package without non-test files Was checking for nil map; must check for empty map instead. Fixes issue 6065 Before: go test -cover # testmain /var/folders/00/013l0000h01000cxqpysvccm0004fc/T/go-build233480051/_/Users/r/issue/_test/_testmain.go:11: imported and not used: "_/Users/r/issue" FAIL _/Users/r/issue [build failed] Now: go test -cover testing: warning: no tests to run PASS coverage: 0.0% of statements ok _/Users/r/issue 0.021s

Patch Set 1 #

Patch Set 2 : diff -r 210830b10a97 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/go/test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years, 7 months ago (2013-08-14 04:03:56 UTC) #1
bradfitz
LGTM On Tue, Aug 13, 2013 at 9:03 PM, <r@golang.org> wrote: > Reviewers: golang-dev1, > ...
10 years, 7 months ago (2013-08-14 16:24:13 UTC) #2
r
10 years, 7 months ago (2013-08-15 00:36:58 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=60eb79a2cd0f ***

cmd/go: fix bad error message in coverage for package without non-test files
Was checking for nil map; must check for empty map instead.

Fixes issue 6065

Before:

go test -cover
# testmain
/var/folders/00/013l0000h01000cxqpysvccm0004fc/T/go-build233480051/_/Users/r/issue/_test/_testmain.go:11:
imported and not used: "_/Users/r/issue"
FAIL	_/Users/r/issue [build failed]

Now:

go test -cover
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok  	_/Users/r/issue	0.021s

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12916043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b