Issue 12914044: Improve HTML for SharePoint user profiles

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12914044: Improve HTML for SharePoint user profiles (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by Tanmay Vartak

Modified:
10 years, 8 months ago

Reviewers:
ejona

CC:
connector-cr_google.com

Visibility:
Public.

More Reviews

Description

Improve HTML for SharePoint user profiles

Patch Set 2 : with html escape #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -8 lines)			Patch
M	src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java	View	1	1 chunk	+1 line, -1 line	1 comment	Download
M	src/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptor.java	View	1	7 chunks	+18 lines, -7 lines	0 comments	Download
M	test/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptorTest.java	View	1	4 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ejona

https://codereview.appspot.com/12914044/diff/1/src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java File src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java (right): https://codereview.appspot.com/12914044/diff/1/src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java#newcode88 src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java:88: authenticationMode = AuthenticationMode.WINDOWS; This looks unrelated. https://codereview.appspot.com/12914044/diff/1/src/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptor.java File src/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptor.java ...

10 years, 8 months ago (2013-08-15 21:35:28 UTC) #2

ejona

10 years, 8 months ago (2013-08-16 16:32:46 UTC) #4

LGTM

https://codereview.appspot.com/12914044/diff/7001/src/com/google/enterprise/a...
File
src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java
(right):

https://codereview.appspot.com/12914044/diff/7001/src/com/google/enterprise/a...
src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java:87:
"Possible SP2013 environment with windows authentication", ex);
You are modifying this line, by adding whitespace at end.

Expand All Messages | Collapse All Messages