Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(614)

Issue 12914044: Improve HTML for SharePoint user profiles (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by Tanmay Vartak
Modified:
7 years, 8 months ago
Reviewers:
ejona
CC:
connector-cr_google.com
Visibility:
Public.

Description

Improve HTML for SharePoint user profiles

Patch Set 1 #

Total comments: 2

Patch Set 2 : with html escape #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -8 lines) Patch
M src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java View 1 1 chunk +1 line, -1 line 1 comment Download
M src/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptor.java View 1 7 chunks +18 lines, -7 lines 0 comments Download
M test/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptorTest.java View 1 4 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Tanmay Vartak
7 years, 9 months ago (2013-08-14 23:31:31 UTC) #1
ejona
https://codereview.appspot.com/12914044/diff/1/src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java File src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java (right): https://codereview.appspot.com/12914044/diff/1/src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java#newcode88 src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java:88: authenticationMode = AuthenticationMode.WINDOWS; This looks unrelated. https://codereview.appspot.com/12914044/diff/1/src/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptor.java File src/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptor.java ...
7 years, 9 months ago (2013-08-15 21:35:28 UTC) #2
Tanmay Vartak
7 years, 9 months ago (2013-08-16 16:14:12 UTC) #3
ejona
7 years, 9 months ago (2013-08-16 16:32:46 UTC) #4
LGTM

https://codereview.appspot.com/12914044/diff/7001/src/com/google/enterprise/a...
File
src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java
(right):

https://codereview.appspot.com/12914044/diff/7001/src/com/google/enterprise/a...
src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java:87:
"Possible SP2013 environment with windows authentication", ex);
You are modifying this line, by adding whitespace at end.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b