Enable server status to be set via control point.

Enable server status to be set via control point.

I'm not sure if goose is used outside of juju-core. Within juju-core the addServer function isn't accessed via a control point in any tests.

This (or something similar) is needed to allow creating test servers within juju-core tests with a specified status [1]

[1] https://code.launchpad.net/~michael.nelson/juju-core/1208504-post-bootstrap-hp-no-instances-found-try2/+merge/179899

https://code.launchpad.net/~michael.nelson/goose/test-instance-state/+merge/180788

(do not edit description out of merge proposal)

[Michael Nelson, 2013-08-19 07:27:28]

Please take a look.

[dimitern, 2013-08-19 07:41:18]

Very good! LGTM with a couple of trivial suggestions.

https://codereview.appspot.com/12897044/diff/1/nova/nova.go
File nova/nova.go (right):

https://codereview.appspot.com/12897044/diff/1/nova/nova.go#newcode31
nova/nova.go:31: StatusBuildSpawning = "BUILD(spawning)" // The HP server has
not finished the original build process but does have networking.
// The server has not finished the original build process but networking works
(HP Cloud specific) ?

https://codereview.appspot.com/12897044/diff/1/testservices/novaservice/servi...
File testservices/novaservice/service_test.go (right):

https://codereview.appspot.com/12897044/diff/1/testservices/novaservice/servi...
testservices/novaservice/service_test.go:263: sr, _ :=
s.service.server(server.Id)
s/sr/server/ ? and change := to =
I think server() already returns a nova.ServerDetail

[Michael Nelson, 2013-08-19 08:05:07]

Please take a look.

https://codereview.appspot.com/12897044/diff/1/nova/nova.go
File nova/nova.go (right):

https://codereview.appspot.com/12897044/diff/1/nova/nova.go#newcode31
nova/nova.go:31: StatusBuildSpawning = "BUILD(spawning)" // The HP server has
not finished the original build process but does have networking.
On 2013/08/19 07:41:18, dimitern wrote:
> // The server has not finished the original build process but networking works
> (HP Cloud specific) ?

Done.

https://codereview.appspot.com/12897044/diff/1/testservices/novaservice/servi...
File testservices/novaservice/service_test.go (right):

https://codereview.appspot.com/12897044/diff/1/testservices/novaservice/servi...
testservices/novaservice/service_test.go:263: sr, _ :=
s.service.server(server.Id)
On 2013/08/19 07:41:18, dimitern wrote:
> s/sr/server/ ? and change := to =
> I think server() already returns a nova.ServerDetail

It returns *nova.ServerDetail, so I updated the previous var to be a pointer and
re-used.

[jameinel, 2013-08-19 08:07:07]

No problems changing 'addServer'.

LGTM