Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(78)

Issue 128930043: code review 128930043: net/http: optional TLSVerifyCallback func for Transport

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 5 months ago by cee-dub
Modified:
7 years, 3 months ago
CC:
agl
Visibility:
Public.

Description

net/http: optional TLSVerify func for Transport Expose a policy hook for TLS that may be used, for example, to check for revoked certificates or other specifics in the certificate chain. Fixes Issue 8522

Patch Set 1 #

Patch Set 2 : diff -r 0449858880beeb4216dc94ac59892205473f6f78 https://code.google.com/p/go #

Patch Set 3 : diff -r 0449858880beeb4216dc94ac59892205473f6f78 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 51c32a31d61112911d9b714733227dba7b7fbd3f https://code.google.com/p/go #

Total comments: 1

Patch Set 5 : diff -r 7e5e03f8413588757bfd33f63a4ebb8d1d8f1753 https://code.google.com/p/go #

Patch Set 6 : diff -r 7e5e03f8413588757bfd33f63a4ebb8d1d8f1753 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -5 lines) Patch
M src/pkg/net/http/transport.go View 1 2 3 4 5 3 chunks +25 lines, -5 lines 0 comments Download
M src/pkg/net/http/transport_test.go View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 8
cee-dub
Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
7 years, 5 months ago (2014-08-12 00:29:03 UTC) #1
bradfitz
https://codereview.appspot.com/128930043/diff/40001/src/pkg/net/http/transport.go File src/pkg/net/http/transport.go (right): https://codereview.appspot.com/128930043/diff/40001/src/pkg/net/http/transport.go#newcode77 src/pkg/net/http/transport.go:77: // TLSVerifyCallback, if non-nil, is invoked right before hostname ...
7 years, 5 months ago (2014-08-13 00:48:45 UTC) #2
cee-dub
https://codereview.appspot.com/128930043/diff/40001/src/pkg/net/http/transport.go File src/pkg/net/http/transport.go (right): https://codereview.appspot.com/128930043/diff/40001/src/pkg/net/http/transport.go#newcode77 src/pkg/net/http/transport.go:77: // TLSVerifyCallback, if non-nil, is invoked right before hostname ...
7 years, 5 months ago (2014-08-13 07:19:57 UTC) #3
cee-dub
Slept on it and came up with simpler code. > You could also say that ...
7 years, 5 months ago (2014-08-13 16:36:04 UTC) #4
agl1
net/http already allows one to handle doing the connection itself, right? If so, is this ...
7 years, 5 months ago (2014-08-13 18:06:47 UTC) #5
pdp
On 2014/08/13 18:06:47, agl1 wrote: > net/http already allows one to handle doing the connection ...
7 years, 5 months ago (2014-08-13 18:19:54 UTC) #6
bradfitz
Per a chat with agl last week, I prepared https://codereview.appspot.com/137940043 which should cover this. It ...
7 years, 4 months ago (2014-09-02 16:40:42 UTC) #7
bradfitz
7 years, 3 months ago (2014-09-29 19:32:33 UTC) #8
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b