Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(431)

Issue 12890043: code review 12890043: net: fix build fix (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by dvyukov
Modified:
11 years, 10 months ago
Reviewers:
bradfitz
CC:
golang-dev
Visibility:
Public.

Description

net: fix build fix Now builders say: pkg/net/dnsclient_unix_test.go:10: imported and not used: "runtime"

Patch Set 1 #

Patch Set 2 : diff -r f9b80e22aa65 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r f9b80e22aa65 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r f9b80e22aa65 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/pkg/net/dnsclient_unix_test.go View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
11 years, 10 months ago (2013-08-13 20:52:50 UTC) #1
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=a00321cd3666 *** net: fix build fix Now builders say: pkg/net/dnsclient_unix_test.go:10: imported and ...
11 years, 10 months ago (2013-08-13 20:55:45 UTC) #2
bradfitz
11 years, 10 months ago (2013-08-13 21:32:00 UTC) #3
LGTM



On Tue, Aug 13, 2013 at 1:52 PM, <dvyukov@google.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
>
https://dvyukov%40google.com@**code.google.com/p/go/<http://40google.com@code...
>
>
> Description:
> net: fix build fix
> Now builders say:
> pkg/net/dnsclient_unix_test.**go:10: imported and not used: "runtime"
>
> Please review this at
https://codereview.appspot.**com/12890043/<https://codereview.appspot.com/128...
>
> Affected files:
>   M src/pkg/net/dnsclient_unix_**test.go
>
>
> Index: src/pkg/net/dnsclient_unix_**test.go
> ==============================**==============================**=======
> --- a/src/pkg/net/dnsclient_unix_**test.go
> +++ b/src/pkg/net/dnsclient_unix_**test.go
> @@ -7,7 +7,6 @@
>  package net
>
>  import (
> -       "runtime"
>         "testing"
>  )
>
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b