code review 12889043: net: fix windows build

net: fix windows build
Windows builders say:
pkg\net\dnsclient_unix_test.go:24: undefined: dnsConfig
pkg\net\dnsclient_unix_test.go:25: undefined: exchange

[dvyukov, 2013-08-13 20:44:35]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[dvyukov, 2013-08-13 20:45:08]

*** Submitted as https://code.google.com/p/go/source/detail?r=f9b80e22aa65 ***

net: fix windows build
Windows builders say:
pkg\net\dnsclient_unix_test.go:24: undefined: dnsConfig
pkg\net\dnsclient_unix_test.go:25: undefined: exchange

R=golang-dev
CC=golang-dev
https://codereview.appspot.com/12889043

[bradfitz, 2013-08-13 20:46:49]

LGTM



On Tue, Aug 13, 2013 at 1:44 PM, <dvyukov@google.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
>
https://dvyukov%40google.com@**code.google.com/p/go/<http://40google.com@code...
>
>
> Description:
> net: fix windows build
> Windows builders say:
> pkg\net\dnsclient_unix_test.**go:24: undefined: dnsConfig
> pkg\net\dnsclient_unix_test.**go:25: undefined: exchange
>
> Please review this at
https://codereview.appspot.**com/12889043/<https://codereview.appspot.com/128...
>
> Affected files:
>   M src/pkg/net/dnsclient_unix_**test.go
>
>
> Index: src/pkg/net/dnsclient_unix_**test.go
> ==============================**==============================**=======
> --- a/src/pkg/net/dnsclient_unix_**test.go
> +++ b/src/pkg/net/dnsclient_unix_**test.go
> @@ -2,6 +2,8 @@
>  // Use of this source code is governed by a BSD-style
>  // license that can be found in the LICENSE file.
>
> +// +build darwin freebsd linux netbsd openbsd
> +
>  package net
>
>  import (
> @@ -10,9 +12,6 @@
>  )
>
>  func TestTCPLookup(t *testing.T) {
> -       if runtime.GOOS == "windows" || runtime.GOOS == "plan9" {
> -               t.Skip("skipping unix dns test")
> -       }
>         if testing.Short() || !*testExternal {
>                 t.Skip("skipping test to avoid external network")
>         }
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>