Issue 12888045: Add a demo tool for scanning the log

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12888045: Add a demo tool for scanning the log

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by ekasper

Modified:
10 years, 8 months ago

Reviewers:
Eran, Ben Laurie (Google)

CC:
ctlog-opensource-review_google.com

Visibility:
Public.

More Reviews

Patch Set 3 : fix another constant #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -0 lines)			Patch
		src/python/ct/client/tools/scan.py	View	1 2	1 chunk	+117 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ekasper

In view of the upcoming Hack Day, here's a little script I hacked together that ...

10 years, 8 months ago (2013-08-22 11:15:47 UTC) #1

Eran

overall looks good (given this is a script that should be ready in time for ...

10 years, 8 months ago (2013-08-23 08:32:09 UTC) #2

ekasper

https://codereview.appspot.com/12888045/diff/1/src/python/ct/client/tools/scan.py File src/python/ct/client/tools/scan.py (right): https://codereview.appspot.com/12888045/diff/1/src/python/ct/client/tools/scan.py#newcode89 src/python/ct/client/tools/scan.py:89: if entry_type == 1: On 2013/08/23 08:32:10, Eran wrote: ...

10 years, 8 months ago (2013-08-23 10:31:02 UTC) #3

LGTM

Expand All Messages | Collapse All Messages