Issue 12884045: code review 12884045: cmd/5g: fix temp-merging on ARM

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12884045: code review 12884045: cmd/5g: fix temp-merging on ARM (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by rsc

Modified:
11 years, 10 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

cmd/5g: fix temp-merging on ARM mkvar was taking care of the "LeftAddr" case, effectively hiding it from the temp-merging optimization. Move it into prog.c.

Patch Set 1 #

Patch Set 2 : diff -r 2bf4cf823da3 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 45e8e962d87b https://code.google.com/p/go/ #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -7 lines)			Patch
	M	src/cmd/5g/prog.c	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
	M	src/cmd/5g/reg.c	View	1	3 chunks	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 10 months ago (2013-08-14 04:34:16 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=3c93433dc31c *** cmd/5g: fix temp-merging on ARM mkvar was taking care of ...

11 years, 10 months ago (2013-08-14 04:34:22 UTC) #2

ken3

11 years, 10 months ago (2013-08-14 06:34:13 UTC) #3

Message was sent while issue was closed.

On 2013/08/14 04:34:22, rsc wrote:
> *** Submitted as https://code.google.com/p/go/source/detail?r=3c93433dc31c ***
> 
> cmd/5g: fix temp-merging on ARM
> 
> mkvar was taking care of the "LeftAddr" case,
> effectively hiding it from the temp-merging optimization.
> 
> Move it into prog.c.
> 
> R=ken2
> CC=golang-dev
> https://codereview.appspot.com/12884045

lgtm

Expand All Messages | Collapse All Messages