code review 12876044: runtime: fix wrong syscall numbers on freebsd/386, open...

runtime: fix wrong syscall numbers on freebsd/386, openbsd/386

[mikio, 2013-08-15 12:46:43]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[mikio, 2013-08-15 12:48:14]

they are changelings.
test passed on both freebsd/386 and openbsd/386.

On Thu, Aug 15, 2013 at 9:46 PM,  <mikioh.mikioh@gmail.com> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> runtime: fix wrong syscall numbers on freebsd/386, openbsd/386
>
> Please review this at https://codereview.appspot.com/12876044/
>
> Affected files:
>   M src/pkg/runtime/sys_freebsd_386.s
>   M src/pkg/runtime/sys_openbsd_386.s
>
>
> Index: src/pkg/runtime/sys_freebsd_386.s
> ===================================================================
> --- a/src/pkg/runtime/sys_freebsd_386.s
> +++ b/src/pkg/runtime/sys_freebsd_386.s
> @@ -350,7 +350,7 @@
>
>  // int32 runtime·kqueue(void);
>  TEXT runtime·kqueue(SB),NOSPLIT,$0
> -       MOVL    $269, AX
> +       MOVL    $362, AX
>         INT     $0x80
>         JAE     2(PC)
>         NEGL    AX
> @@ -358,7 +358,7 @@
>
>  // int32 runtime·kevent(int kq, Kevent *changelist, int nchanges, Kevent
> *eventlist, int nevents, Timespec *timeout);
>  TEXT runtime·kevent(SB),NOSPLIT,$0
> -       MOVL    $270, AX
> +       MOVL    $363, AX
>         INT     $0x80
>         JAE     2(PC)
>         NEGL    AX
> Index: src/pkg/runtime/sys_openbsd_386.s
> ===================================================================
> --- a/src/pkg/runtime/sys_openbsd_386.s
> +++ b/src/pkg/runtime/sys_openbsd_386.s
> @@ -354,7 +354,7 @@
>
>  // int32 runtime·kqueue(void);
>  TEXT runtime·kqueue(SB),NOSPLIT,$0
> -       MOVL    $362, AX
> +       MOVL    $269, AX
>         INT     $0x80
>         JAE     2(PC)
>         NEGL    AX
> @@ -362,7 +362,7 @@
>
>  // int32 runtime·kevent(int kq, Kevent *changelist, int nchanges, Kevent
> *eventlist, int nevents, Timespec *timeout);
>  TEXT runtime·kevent(SB),NOSPLIT,$0
> -       MOVL    $363, AX
> +       MOVL    $270, AX
>         INT     $0x80
>         JAE     2(PC)
>         NEGL    AX
>
>

[jsing, 2013-08-15 14:00:57]

LGTM

I was just about to send an identical CL :)

[mikio, 2013-08-15 14:23:03]

*** Submitted as https://code.google.com/p/go/source/detail?r=0a5af862666a ***

runtime: fix wrong syscall numbers on freebsd/386, openbsd/386

R=golang-dev, jsing
CC=golang-dev
https://codereview.appspot.com/12876044