code review 128720043: go/doc/headscan: update script to count headings with a...

go/doc/headscan: update script to count headings with an ID attribute

Fixes script used to sanity-check the heading-detection heuristic of go/doc.
Fixes issue 8467.

[esk, 2014-08-07 04:05:29]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[gobot, 2014-08-26 17:50:16]

R=gri@golang.org (assigned by r@golang.org)

[gri, 2014-08-26 20:41:05]

https://codereview.appspot.com/128720043/diff/20001/src/pkg/go/doc/headscan.go
File src/pkg/go/doc/headscan.go (right):

https://codereview.appspot.com/128720043/diff/20001/src/pkg/go/doc/headscan.g...
src/pkg/go/doc/headscan.go:35: html_h  = regexp.MustCompile(`<h3
id="hdr-[^>]+>`)
this is not a flag, move it into separate declaration, please

var html_h = regexp.MustCompile(`<h3 id="[^"]*">`)

There should also be a comment tying this and the const below to the
corresponding values in comment.go.

https://codereview.appspot.com/128720043/diff/20001/src/pkg/go/doc/headscan.g...
src/pkg/go/doc/headscan.go:38: const (
no need for the ()'s

[esk, 2014-08-30 16:22:16]

https://codereview.appspot.com/128720043/diff/20001/src/pkg/go/doc/headscan.go
File src/pkg/go/doc/headscan.go (right):

https://codereview.appspot.com/128720043/diff/20001/src/pkg/go/doc/headscan.g...
src/pkg/go/doc/headscan.go:35: html_h  = regexp.MustCompile(`<h3
id="hdr-[^>]+>`)
On 2014/08/26 20:41:05, gri wrote:
> this is not a flag, move it into separate declaration, please
> 
> var html_h = regexp.MustCompile(`<h3 id="[^"]*">`)
> 
> There should also be a comment tying this and the const below to the
> corresponding values in comment.go.

Done.

https://codereview.appspot.com/128720043/diff/20001/src/pkg/go/doc/headscan.g...
src/pkg/go/doc/headscan.go:38: const (
On 2014/08/26 20:41:05, gri wrote:
> no need for the ()'s

Done.

[gri, 2014-08-30 17:25:18]

LGTM

[gri, 2014-08-30 17:27:39]

*** Submitted as https://code.google.com/p/go/source/detail?r=6cadf291593e ***

go/doc/headscan: update script to count headings with an ID attribute

Fixes script used to sanity-check the heading-detection heuristic of go/doc.
Fixes issue 8467.

LGTM=gri
R=golang-codereviews, gobot, gri
CC=golang-codereviews
https://codereview.appspot.com/128720043

Committer: Robert Griesemer <gri@golang.org>

[gobot, 2014-08-30 20:33:40]

This CL appears to have broken the openbsd-386-rootbsd builder.
See http://build.golang.org/log/5a36ed414f4aaeb3337ecc24a36e17d2f3c6430f

[esk, 2014-08-31 03:36:25]

*** Abandoned ***