Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(511)

Issue 128720043: code review 128720043: go/doc/headscan: update script to count headings with a... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by esk
Modified:
11 years, 2 months ago
Reviewers:
gobot, gri
CC:
golang-codereviews, gri
Visibility:
Public.

Description

go/doc/headscan: update script to count headings with an ID attribute Fixes script used to sanity-check the heading-detection heuristic of go/doc. Fixes issue 8467.

Patch Set 1 #

Patch Set 2 : diff -r 6b696a34e0af https://code.google.com/p/go/ #

Total comments: 4

Patch Set 3 : diff -r 1041a5493f10e3c6edadc67e683f6aa6d832fd60 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M src/pkg/go/doc/headscan.go View 1 2 3 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 8
esk
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 3 months ago (2014-08-07 04:05:29 UTC) #1
gobot
R=gri@golang.org (assigned by r@golang.org)
11 years, 2 months ago (2014-08-26 17:50:16 UTC) #2
gri
https://codereview.appspot.com/128720043/diff/20001/src/pkg/go/doc/headscan.go File src/pkg/go/doc/headscan.go (right): https://codereview.appspot.com/128720043/diff/20001/src/pkg/go/doc/headscan.go#newcode35 src/pkg/go/doc/headscan.go:35: html_h = regexp.MustCompile(`<h3 id="hdr-[^>]+>`) this is not a flag, ...
11 years, 2 months ago (2014-08-26 20:41:05 UTC) #3
esk
https://codereview.appspot.com/128720043/diff/20001/src/pkg/go/doc/headscan.go File src/pkg/go/doc/headscan.go (right): https://codereview.appspot.com/128720043/diff/20001/src/pkg/go/doc/headscan.go#newcode35 src/pkg/go/doc/headscan.go:35: html_h = regexp.MustCompile(`<h3 id="hdr-[^>]+>`) On 2014/08/26 20:41:05, gri wrote: ...
11 years, 2 months ago (2014-08-30 16:22:16 UTC) #4
gri
LGTM
11 years, 2 months ago (2014-08-30 17:25:18 UTC) #5
gri
*** Submitted as https://code.google.com/p/go/source/detail?r=6cadf291593e *** go/doc/headscan: update script to count headings with an ID attribute ...
11 years, 2 months ago (2014-08-30 17:27:39 UTC) #6
gobot
This CL appears to have broken the openbsd-386-rootbsd builder. See http://build.golang.org/log/5a36ed414f4aaeb3337ecc24a36e17d2f3c6430f
11 years, 2 months ago (2014-08-30 20:33:40 UTC) #7
esk
11 years, 2 months ago (2014-08-31 03:36:25 UTC) #8
Message was sent while issue was closed.
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b