Fixes #1207041 environment view shifts in IE

Fixes #1207041 environment view shifts in IE

Two changes, these are QA only.

- Drive by, the feedback tab should overlay the zoom slider when you hover
over it. Upped its z-index so it's over the zoom slider when hovered.
- IE would shift the whole environment when the charm details did the
scrollIntoView call. This is done so that if you scroll down on one charm, and
then click a second charm in the results list on the left, you want to reset
the scroll position. It turns out IE hates scrollIntoView and ran into some
hints in the question:
http://stackoverflow.com/questions/11039885/scrollintoview-causing-the-whole-page-to-move

This changes the scrollIntoView into a hard coded scrollTop which works to
reset the position and works in all browsers in QA.

https://code.launchpad.net/~rharding/juju-gui/ie-moving-environment/+merge/180341

(do not edit description out of merge proposal)

[rharding, 2013-08-15 13:28:51]

Please take a look.

[benji, 2013-08-15 13:32:33]

LGTM with a couple of small comments.

https://codereview.appspot.com/12871046/diff/1/app/subapps/browser/views/char...
File app/subapps/browser/views/charm.js (right):

https://codereview.appspot.com/12871046/diff/1/app/subapps/browser/views/char...
app/subapps/browser/views/charm.js:750: renderTo._node.scrollTop = 0;
Good comment.

I guess if we want the non-jumping behavior back in the future we can do browser
sniffing.

https://codereview.appspot.com/12871046/diff/1/lib/views/stylesheet.less
File lib/views/stylesheet.less (right):

https://codereview.appspot.com/12871046/diff/1/lib/views/stylesheet.less#newc...
lib/views/stylesheet.less:914: z-index: 10;
Should we comment this so we know why it's here?

[benji, 2013-08-15 13:32:35]

LGTM with a couple of small comments.

[rharding, 2013-08-15 13:37:39]

On 2013/08/15 13:32:33, benji wrote:
> LGTM with a couple of small comments.
> 
>
https://codereview.appspot.com/12871046/diff/1/app/subapps/browser/views/char...
> File app/subapps/browser/views/charm.js (right):
> 
>
https://codereview.appspot.com/12871046/diff/1/app/subapps/browser/views/char...
> app/subapps/browser/views/charm.js:750: renderTo._node.scrollTop = 0;
> Good comment.
> 
> I guess if we want the non-jumping behavior back in the future we can do
browser
> sniffing.

Actually, in testing the current behaviour it's jumpy so I don't think we're
losing anything.

> https://codereview.appspot.com/12871046/diff/1/lib/views/stylesheet.less
> File lib/views/stylesheet.less (right):
> 
>
https://codereview.appspot.com/12871046/diff/1/lib/views/stylesheet.less#newc...
> lib/views/stylesheet.less:914: z-index: 10;
> Should we comment this so we know why it's here?

Will add.

[benji, 2013-08-15 13:46:27]

On 2013/08/15 13:37:39, rharding wrote:
> On 2013/08/15 13:32:33, benji wrote:

> > I guess if we want the non-jumping behavior back in the future we can do
> browser
> > sniffing.
> 
> Actually, in testing the current behaviour it's jumpy so I don't think we're
> losing anything.

Well, that's good... I guess. :)

[j.c.sackett, 2013-08-15 13:59:33]

LGTM.

This QAs on IE10 for me, and nicely doesn't break anything on FF on linux. :-)

I'll note that we use scrollIntoView in app/subapps/browser/views/search.js as
well, though. You might want to check if the fix is needed there as well.

[rharding, 2013-08-15 14:16:42]

*** Submitted:

Fixes #1207041 environment view shifts in IE

Two changes, these are QA only.

- Drive by, the feedback tab should overlay the zoom slider when you hover
over it. Upped its z-index so it's over the zoom slider when hovered.
- IE would shift the whole environment when the charm details did the
scrollIntoView call. This is done so that if you scroll down on one charm, and
then click a second charm in the results list on the left, you want to reset
the scroll position. It turns out IE hates scrollIntoView and ran into some
hints in the question:
http://stackoverflow.com/questions/11039885/scrollintoview-causing-the-whole-...

This changes the scrollIntoView into a hard coded scrollTop which works to
reset the position and works in all browsers in QA.

R=benji, j.c.sackett
CC=
https://codereview.appspot.com/12871046