Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(85)

Issue 12869048: code review 12869048: cmd/go: add 'oracle' to list of tools. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 10 months ago by adonovan
Modified:
8 years, 10 months ago
Reviewers:
r, adg, gri
CC:
golang-dev
Visibility:
Public.

Description

cmd/go: add 'oracle' to list of tools. (Oracle itself is in CL 9502043.)

Patch Set 1 #

Patch Set 2 : diff -r 14a416a72f8c https://code.google.com/p/go/ #

Patch Set 3 : diff -r 14a416a72f8c https://code.google.com/p/go/ #

Patch Set 4 : diff -r 14a416a72f8c https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M src/cmd/go/pkg.go View 1 1 chunk +8 lines, -7 lines 0 comments Download
M src/cmd/go/tool.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
adonovan
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
8 years, 10 months ago (2013-08-22 17:58:33 UTC) #1
adonovan
Hello r@golang.org, gri@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
8 years, 10 months ago (2013-08-22 17:59:09 UTC) #2
r
What is the oracle? What does it do? It's not even checked in yet.
8 years, 10 months ago (2013-08-22 21:54:03 UTC) #3
adonovan
On 22 August 2013 17:53, Rob Pike <r@golang.org> wrote: > What is the oracle? What ...
8 years, 10 months ago (2013-08-22 22:29:55 UTC) #4
adg
Since this isn't really a command-line tool I'm not sure it's worth making it accessible ...
8 years, 10 months ago (2013-08-23 00:09:26 UTC) #5
r
I tend to agree. It may move to 'tool' status at some point but we ...
8 years, 10 months ago (2013-08-23 00:22:14 UTC) #6
adonovan
*** Abandoned ***
8 years, 10 months ago (2013-08-26 18:51:03 UTC) #7
adonovan
8 years, 10 months ago (2013-08-26 21:18:28 UTC) #8
adg wrote:
> Since this isn't really a command-line tool I'm not sure it's worth
making it accessible through the go tool.

On 22 August 2013 20:21, Rob Pike <r@golang.org> wrote:

> I tend to agree. It may move to 'tool' status at some point but we
> need to see it in action, and have it more generally useful (that is,
> not just an emacs plugin), before making that decision.
>
> For the record: All it takes for a local installation to have 'go tool
> oracle' work is to copy the binary to the tool directory. The 'go
> tool' command is just a shorthand for running a binary from that
> directory.
>
> That solution seems workable and sufficiently non-committal for the moment.
>

I've reverted this CL for now, but I should point out that the alternative
is significantly more fiddly.  Even though the user is not expected to run
the oracle tool directly, the benefit of being a 'go tool' subcommand is
that both installation and invocation of the oracle have one and only one
configuration requirement: that there be a command called 'go'.  (In my
setup, for example, 'go' is a wrapper that selects the appropriate GOROOT
and GOPATH---each of which I have several---based on the working directory,
then dispatches to the real 'go' tool binary.)

So expect this CL to reappear when the oracle is more mature. :)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b