Issue 12862044: Fix missing locale and email in determining subscribers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12862044: Fix missing locale and email in determining subscribers (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by ana.balica

Modified:
10 years, 8 months ago

Reviewers:
thomas.j.waldmann

Visibility:
Public.

More Reviews

Description

Fix missing locale and email in determining subscribers

Patch Set 2 : Get locale in a better way #

Total comments: 1

Patch Set 3 : #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -14 lines)			Patch
M	MoinMoin/constants/keys.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	MoinMoin/util/_tests/test_subscriptions.py	View		2 chunks	+19 lines, -9 lines	0 comments	Download
M	MoinMoin/util/subscriptions.py	View	1 2	2 chunks	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Thomas.J.Waldmann

https://codereview.appspot.com/12862044/diff/1/MoinMoin/constants/keys.py File MoinMoin/constants/keys.py (right): https://codereview.appspot.com/12862044/diff/1/MoinMoin/constants/keys.py#newcode130 MoinMoin/constants/keys.py:130: DEFAULT_LOCALE = u"en" is this enough as locale? don't ...

10 years, 8 months ago (2013-08-27 15:18:07 UTC) #1

ana.balica

10 years, 8 months ago (2013-08-27 16:28:50 UTC) #2

Thomas.J.Waldmann

10 years, 8 months ago (2013-08-27 16:37:05 UTC) #3

https://codereview.appspot.com/12862044/diff/7001/MoinMoin/util/subscriptions.py
File MoinMoin/util/subscriptions.py (right):

https://codereview.appspot.com/12862044/diff/7001/MoinMoin/util/subscriptions...
MoinMoin/util/subscriptions.py:53: subscribers.add(Subscriber(user[ITEMID],
user[NAME][0], email, locale))
well, it's only a minor thing, but maybe more elegant:

email = user.get(EMAIL)
if email:
    locale = user.get(....)
    subscribers.add(....)

Expand All Messages | Collapse All Messages