code review 12858044: tests: remove two misuses of nil pointers

tests: remove two misuses of nil pointers

[rsc, 2013-08-15 15:47:41]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-08-15 15:48:34]

LGTM



On Thu, Aug 15, 2013 at 8:47 AM, <rsc@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> tests: remove two misuses of nil pointers
>
> Please review this at
https://codereview.appspot.**com/12858044/<https://codereview.appspot.com/128...
>
> Affected files:
>   M src/pkg/runtime/gc_test.go
>   M test/recover3.go
>
>
> Index: src/pkg/runtime/gc_test.go
> ==============================**==============================**=======
> --- a/src/pkg/runtime/gc_test.go
> +++ b/src/pkg/runtime/gc_test.go
> @@ -136,7 +136,9 @@
>         for i := 0; i < 10; i++ {
>                 p := &Y{}
>                 p.c = make(chan error)
> -               p.nextx = &head.X
> +               if head != nil {
> +                       p.nextx = &head.X
> +               }
>                 p.nexty = head
>                 p.p = new(int)
>                 *p.p = 42
> Index: test/recover3.go
> ==============================**==============================**=======
> --- a/test/recover3.go
> +++ b/test/recover3.go
> @@ -64,7 +64,8 @@
>
>         i = 99999
>         var sl []int
> -       check("array-bounds", func() { println(p[i]) }, "index out of
> range")
> +       p1 := new([10]int)
> +       check("array-bounds", func() { println(p1[i]) }, "index out of
> range")
>         check("slice-bounds", func() { println(sl[i]) }, "index out of
> range")
>
>         var inter interface{}
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[rsc, 2013-08-15 15:51:11]

*** Submitted as https://code.google.com/p/go/source/detail?r=0317258d3683 ***

tests: remove two misuses of nil pointers

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/12858044