Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2098)

Issue 12857043: Excludes grobs supported by cross-staff grobs from pure-relevant calculations

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by MikeSol
Modified:
10 years, 8 months ago
Reviewers:
Keith, mike7
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Excludes grobs supported by cross-staff grobs from pure-relevant calculations

Patch Set 1 #

Patch Set 2 : Allows all items to be pure relevant #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -9 lines) Patch
M lily/axis-group-interface.cc View 1 2 chunks +9 lines, -9 lines 1 comment Download
M lily/include/side-position-interface.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/side-position-interface.cc View 1 chunk +16 lines, -0 lines 2 comments Download

Messages

Total messages: 3
MikeSol
Allows all items to be pure relevant
10 years, 8 months ago (2013-08-13 17:58:52 UTC) #1
Keith
https://codereview.appspot.com/12857043/diff/3001/lily/axis-group-interface.cc File lily/axis-group-interface.cc (right): https://codereview.appspot.com/12857043/diff/3001/lily/axis-group-interface.cc#newcode504 lily/axis-group-interface.cc:504: && dynamic_cast<Spanner *> (elts[i]))) So if a spanner lies ...
10 years, 8 months ago (2013-08-14 05:34:18 UTC) #2
mike7
10 years, 8 months ago (2013-08-14 05:37:00 UTC) #3
https://codereview.appspot.com/12857043/diff/3001/lily/side-position-interfac...
File lily/side-position-interface.cc (right):

https://codereview.appspot.com/12857043/diff/3001/lily/side-position-interfac...
lily/side-position-interface.cc:283: && cross_staff
On 2013/08/14 05:34:18, Keith wrote:
> Under these conditions,
>  trying to estimate before line-breaking  (pure)
>  where an object 'me' will align vertically (Y_AXIS)
>  against an object 'e' whose position depends on staff-spacing (cross-staff)
> we might want to skip this object 'e', whether 'e' is a stem or not.
> 
> If it is a stem, since we know it is cross-staff, is the test on the next line
> of the stem's direction going to be reliable ?  It seems best to skip the stem
> and estimate the alignment against the remaining objects in 'support'.

Great ideas - I like this better.  Will do.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b