Issue 12852045: Removes the bws-icon from fullscreen

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12852045: Removes the bws-icon from fullscreen

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by j.c.sackett

Modified:
10 years, 8 months ago

Reviewers:
jeff.pihach, matthew.scott, mp+180917

Visibility:
Public.

Description

Removes the bws-icon from fullscreen The bws-icon handles minimizing the sidebar view; we don't need it in fullscreen, it shouldn't render, and when it does it causes errors and renders oddly. https://code.launchpad.net/~jcsackett/juju-gui/floating-sidebar-handle/+merge/180917 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Removes the bws-icon from fullscreen #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -12 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/subapps/browser/templates/fullscreen.handlebars	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	test/test_browser_app.js	View		1 chunk	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

j.c.sackett

10 years, 8 months ago (2013-08-19 18:33:47 UTC) #4

*** Submitted:

Removes the bws-icon from fullscreen

The bws-icon handles minimizing the sidebar view; we don't need it in
fullscreen, it shouldn't render, and when it does it causes errors and renders
oddly.

R=matthew.scott, jeff.pihach
CC=
https://codereview.appspot.com/12852045

Expand All Messages | Collapse All Messages