Issue 12848048: code review 12848048: odbc: say that data and canBeNull can be null in TestMS...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12848048: code review 12848048: odbc: say that data and canBeNull can be null in TestMS... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by brainman

Modified:
11 years, 10 months ago

Reviewers:

CC:
brainman, gv

Visibility:
Public.

Description

odbc: say that data and canBeNull can be null in TestMSSQLCreateInsertDelete Fixes issue 15

Patch Set 1 #

Patch Set 2 : diff -r 73cbd9ce014c https://code.google.com/p/odbc #

Patch Set 3 : diff -r 73cbd9ce014c https://code.google.com/p/odbc #

Patch Set 4 : diff -r 73cbd9ce014c https://code.google.com/p/odbc #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	mssql_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

brainman

Hello brainman, I'd like you to review this change to https://code.google.com/p/odbc

11 years, 10 months ago (2013-08-22 07:20:58 UTC) #1

Looks good to me, the same change works in my environment. On 2013/08/22 07:20:58, brainman ...

11 years, 10 months ago (2013-08-22 09:04:28 UTC) #2

brainman

11 years, 10 months ago (2013-08-22 23:38:37 UTC) #3

*** Submitted as https://code.google.com/p/odbc/source/detail?r=e76d703f5f45 ***

odbc: say that data and canBeNull can be null in TestMSSQLCreateInsertDelete

Fixes issue 15

R=alex.brainman, govert
CC=brainman
https://codereview.appspot.com/12848048

Expand All Messages | Collapse All Messages