Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1309)

Issue 12843043: code review 12843043: net: fix dial to raw IP networks on Windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by mikio
Modified:
6 years, 9 months ago
Reviewers:
brainman, tegoor
CC:
brainman, golang-dev
Visibility:
Public.

Description

net: fix dial to raw IP networks on Windows Also avoids platform-dependent datagram truncation in raw IP tests. At least it's different between Windows and others. Fixes issue 6122.

Patch Set 1 #

Patch Set 2 : diff -r bfc402b61fc1 https://code.google.com/p/go #

Patch Set 3 : diff -r bfc402b61fc1 https://code.google.com/p/go #

Patch Set 4 : diff -r b68d5c753d91 https://code.google.com/p/go #

Patch Set 5 : diff -r 0593b48602fa https://code.google.com/p/go #

Patch Set 6 : diff -r 646b13b8c136 https://code.google.com/p/go #

Patch Set 7 : diff -r 646b13b8c136 https://code.google.com/p/go #

Patch Set 8 : diff -r 646b13b8c136 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -23 lines) Patch
M src/pkg/net/fd_windows.go View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M src/pkg/net/ipraw_test.go View 1 2 3 4 5 6 9 chunks +43 lines, -18 lines 0 comments Download
M src/pkg/net/protoconn_test.go View 1 2 3 4 5 6 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 20
mikio
Hello alex.brainman@gmail.com, dvyukov@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
6 years, 9 months ago (2013-08-13 07:01:05 UTC) #1
mikio
Sorry, I have no windows stuff; didn't test this CL on windows. I'm happy if ...
6 years, 9 months ago (2013-08-13 07:08:07 UTC) #2
brainman
On 2013/08/13 07:08:07, mikio wrote: > Sorry, I have no windows stuff; didn't test this ...
6 years, 9 months ago (2013-08-13 07:16:43 UTC) #3
mikio
Thanks. Wow, looks like, - I/O thru PacketConn: okay - I/O thru Conn: ng - ...
6 years, 9 months ago (2013-08-13 07:21:40 UTC) #4
brainman
My previous post was on windows-386 Windows XP. The following is windows-amd64 Windows 7 Pro: ...
6 years, 9 months ago (2013-08-13 07:27:26 UTC) #5
mikio
sobbing... On Tue, Aug 13, 2013 at 4:27 PM, <alex.brainman@gmail.com> wrote: > My previous post ...
6 years, 9 months ago (2013-08-13 07:31:37 UTC) #6
brainman
mikio, I think we need to fix this before 1.2. The change is fine, but, ...
6 years, 9 months ago (2013-08-21 05:47:26 UTC) #7
mikio
yup, just sent a few CLs for that purpose; to run raw IP tests on ...
6 years, 9 months ago (2013-08-21 08:27:35 UTC) #8
brainman
On 2013/08/21 08:27:35, mikio wrote: > yup, just sent a few CLs for that purpose; ...
6 years, 9 months ago (2013-08-22 01:07:42 UTC) #9
mikio
Will add test case for this regression once preliminary CLs landed, 12796047 and 12898045. Please ...
6 years, 9 months ago (2013-08-22 01:31:09 UTC) #10
brainman
On 2013/08/22 01:31:09, mikio wrote: > Will add test case for this regression once preliminary ...
6 years, 9 months ago (2013-08-22 01:44:53 UTC) #11
mikio
On Thu, Aug 22, 2013 at 10:44 AM, <alex.brainman@gmail.com> wrote: > No. Please do it ...
6 years, 9 months ago (2013-08-22 02:06:19 UTC) #12
mikio
Here you go. I think now all tests for raw IP stuff runs on windows ...
6 years, 9 months ago (2013-08-22 02:56:45 UTC) #13
brainman
On 2013/08/22 02:56:45, mikio wrote: > > Please try TestConnICMPEcho, TestPacketConnICMPEcho and/or > TestPacketConn, TestIPConnSpecificMethods ...
6 years, 9 months ago (2013-08-23 06:39:30 UTC) #14
mikio
Hello alex.brainman@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
6 years, 9 months ago (2013-08-23 08:01:48 UTC) #15
mikio
Thanks for the confirmation. On Fri, Aug 23, 2013 at 3:39 PM, <alex.brainman@gmail.com> wrote: > ...
6 years, 9 months ago (2013-08-23 08:02:31 UTC) #16
brainman
LGTM Fingers crossed. :-) Alex
6 years, 9 months ago (2013-08-23 10:01:21 UTC) #17
mikio
*** Submitted as https://code.google.com/p/go/source/detail?r=9810b5abd0ab *** net: fix dial to raw IP networks on Windows Also ...
6 years, 9 months ago (2013-08-23 10:31:35 UTC) #18
tegoor_gmail.com
--- FAIL: TestConnICMPEcho (0.33 seconds) ipraw_test.go:132: Conn.Read failed: WSARecv ip6 ::1: i/o timeout --- FAIL: ...
6 years, 9 months ago (2013-09-02 09:14:46 UTC) #19
mikio
6 years, 9 months ago (2013-09-02 21:54:29 UTC) #20
Hi,

> --- FAIL: TestConnICMPEcho (0.33 seconds)
>         ipraw_test.go:132: Conn.Read failed: WSARecv ip6 ::1: i/o timeout
> --- FAIL: TestPacketConnICMPEcho (0.12 seconds)
>         ipraw_test.go:210: PacketConn.ReadFrom failed: WSARecvFrom ip6 :::
> i/o t
> imeout
> FAIL
> FAIL    net     8.203s

Thanks, please file an issue.
Windows version, result of "ping -6 ::1", and captured data on
loopback interface (if possible) might be great help.

> ICMPv6 checksum missed?

I have no clue.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b