Issue 12842044: code review 12842044: runtime: Fix netbsd/arm and freebsd/arm build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12842044: code review 12842044: runtime: Fix netbsd/arm and freebsd/arm build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by elias.naur

Modified:
11 years, 7 months ago

Reviewers:
rsc

CC:
rsc, golang-dev

Visibility:
Public.

Description

runtime: Fix netbsd/arm and freebsd/arm build The ARM external linking CL left missed changes to sys_freebsd_arm.s and sys_netbsd_arm.s already done to sys_linux_arm.s.

Patch Set 1 #

Patch Set 2 : diff -r 52572649a0d2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 52572649a0d2 https://go.googlecode.com/hg/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	src/pkg/runtime/sys_freebsd_arm.s	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
	M	src/pkg/runtime/sys_netbsd_arm.s	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

elias.naur

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 7 months ago (2013-08-14 17:15:45 UTC) #1

rsc

11 years, 7 months ago (2013-08-14 17:19:45 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=fb5377214a40 ***

runtime: Fix netbsd/arm and freebsd/arm build

        The ARM external linking CL left missed changes to sys_freebsd_arm.s and
sys_netbsd_arm.s already done to sys_linux_arm.s.

R=rsc
CC=golang-dev
https://codereview.appspot.com/12842044

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages