Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(431)

Issue 128380043: code review 128380043: runtime: fix MemStats on 32-bits (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by dvyukov
Modified:
10 years, 7 months ago
Reviewers:
gobot, khr, dave
CC:
golang-codereviews, khr, rsc, rlh
Visibility:
Public.

Description

runtime: fix MemStats on 32-bits Int64's do not fit into uintptr's.

Patch Set 1 #

Patch Set 2 : diff -r 55f09668f3b265c909e04580abec3ba84add2bae https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r b86ee06ef235d5766845f44056f152e1808da110 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r b86ee06ef235d5766845f44056f152e1808da110 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 2

Patch Set 5 : diff -r 40ba12acfb6a873bab35d63ca1198d5f5e486482 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r 40ba12acfb6a873bab35d63ca1198d5f5e486482 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M src/pkg/runtime/gc_test.go View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/pkg/runtime/malloc.go View 1 2 3 4 1 chunk +4 lines, -3 lines 0 comments Download
M src/pkg/runtime/mgc0.c View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9
dvyukov
Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rlh@golang.org, rsc@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 7 months ago (2014-08-18 13:46:46 UTC) #1
khr
On 2014/08/18 13:46:46, dvyukov wrote: > Hello mailto:golang-codereviews@googlegroups.com (cc: mailto:khr@golang.org, mailto:rlh@golang.org, > mailto:rsc@golang.org), > > ...
10 years, 7 months ago (2014-08-18 20:35:03 UTC) #2
rsc
https://codereview.appspot.com/128380043/diff/60001/src/pkg/runtime/malloc.go File src/pkg/runtime/malloc.go (right): https://codereview.appspot.com/128380043/diff/60001/src/pkg/runtime/malloc.go#newcode489 src/pkg/runtime/malloc.go:489: mp.scalararg[0] = uint((uint64(startTime) << 32) >> 32) // low ...
10 years, 7 months ago (2014-08-18 22:59:43 UTC) #3
dvyukov
https://codereview.appspot.com/128380043/diff/60001/src/pkg/runtime/malloc.go File src/pkg/runtime/malloc.go (right): https://codereview.appspot.com/128380043/diff/60001/src/pkg/runtime/malloc.go#newcode489 src/pkg/runtime/malloc.go:489: mp.scalararg[0] = uint((uint64(startTime) << 32) >> 32) // low ...
10 years, 7 months ago (2014-08-19 07:52:42 UTC) #4
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=677c0cd37d62 *** runtime: fix MemStats on 32-bits Int64's do not fit into ...
10 years, 7 months ago (2014-08-19 07:53:26 UTC) #5
gobot
This CL appears to have broken the windows-amd64 builder. See http://build.golang.org/log/d6718ea67541b8c6be2bb14bcbc4e1c4261f67d7
10 years, 7 months ago (2014-08-19 08:26:14 UTC) #6
dave_cheney.net
On 2014/08/19 08:26:14, gobot wrote: > This CL appears to have broken the windows-amd64 builder. ...
10 years, 7 months ago (2014-08-19 09:20:23 UTC) #7
dvyukov
mailed https://codereview.appspot.com/127520043 to fix it On Tue, Aug 19, 2014 at 1:20 PM, <dave@cheney.net> wrote: ...
10 years, 7 months ago (2014-08-19 10:28:33 UTC) #8
gobot
10 years, 7 months ago (2014-08-19 11:15:24 UTC) #9
Message was sent while issue was closed.
This CL appears to have broken the linux-and64-perf builder.
See http://build.golang.org/log/05d7e54c7616fad26edcc534107bb163a785dad0
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b