code review 128380043: runtime: fix MemStats on 32-bits

runtime: fix MemStats on 32-bits
Int64's do not fit into uintptr's.

[dvyukov, 2014-08-18 13:46:46]

Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rlh@golang.org,
rsc@golang.org),

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[khr, 2014-08-18 20:35:03]

On 2014/08/18 13:46:46, dvyukov wrote:
> Hello mailto:golang-codereviews@googlegroups.com (cc: mailto:khr@golang.org,
mailto:rlh@golang.org,
> mailto:rsc@golang.org),
> 
> I'd like you to review this change to
> https://dvyukov%40google.com@code.google.com/p/go/

LGTM.

[rsc, 2014-08-18 22:59:43]

https://codereview.appspot.com/128380043/diff/60001/src/pkg/runtime/malloc.go
File src/pkg/runtime/malloc.go (right):

https://codereview.appspot.com/128380043/diff/60001/src/pkg/runtime/malloc.go...
src/pkg/runtime/malloc.go:489: mp.scalararg[0] = uint((uint64(startTime) << 32)
>> 32) // low 32 bits
Much simpler:

mp.scalararg[0] = uint(uint32(startTime))
mp.scalararg[1] = uint(startTime>>32)

[dvyukov, 2014-08-19 07:52:42]

https://codereview.appspot.com/128380043/diff/60001/src/pkg/runtime/malloc.go
File src/pkg/runtime/malloc.go (right):

https://codereview.appspot.com/128380043/diff/60001/src/pkg/runtime/malloc.go...
src/pkg/runtime/malloc.go:489: mp.scalararg[0] = uint((uint64(startTime) << 32)
>> 32) // low 32 bits
On 2014/08/18 22:59:43, rsc wrote:
> Much simpler:
> 
> mp.scalararg[0] = uint(uint32(startTime))
> mp.scalararg[1] = uint(startTime>>32)

Done.

[dvyukov, 2014-08-19 07:53:26]

*** Submitted as https://code.google.com/p/go/source/detail?r=677c0cd37d62 ***

runtime: fix MemStats on 32-bits
Int64's do not fit into uintptr's.

LGTM=khr
R=golang-codereviews, khr, rsc
CC=golang-codereviews, rlh
https://codereview.appspot.com/128380043

[gobot, 2014-08-19 08:26:14]

This CL appears to have broken the windows-amd64 builder.
See http://build.golang.org/log/d6718ea67541b8c6be2bb14bcbc4e1c4261f67d7

[dave_cheney.net, 2014-08-19 09:20:23]

On 2014/08/19 08:26:14, gobot wrote:
> This CL appears to have broken the windows-amd64 builder.
> See http://build.golang.org/log/d6718ea67541b8c6be2bb14bcbc4e1c4261f67d7

Yup, both windows builders


# GOMAXPROCS=2 runtime -cpu=1,2,4
--- FAIL: TestGcLastTime (0.00s)
	gc_test.go:169: bad last GC pause: got 0, want [0, 10e9]
--- FAIL: TestGcLastTime-4 (0.00s)
	gc_test.go:169: bad last GC pause: got 0, want [0, 10e9]
FAIL
FAIL	runtime	156.737s
Build complete, duration 20m5.164s. Result: error: exit status 1

[dvyukov, 2014-08-19 10:28:33]

mailed https://codereview.appspot.com/127520043 to fix it

On Tue, Aug 19, 2014 at 1:20 PM,  <dave@cheney.net> wrote:
> On 2014/08/19 08:26:14, gobot wrote:
>>
>> This CL appears to have broken the windows-amd64 builder.
>> See
>
> http://build.golang.org/log/d6718ea67541b8c6be2bb14bcbc4e1c4261f67d7
>
> Yup, both windows builders
>
>
> # GOMAXPROCS=2 runtime -cpu=1,2,4
> --- FAIL: TestGcLastTime (0.00s)
>         gc_test.go:169: bad last GC pause: got 0, want [0, 10e9]
> --- FAIL: TestGcLastTime-4 (0.00s)
>         gc_test.go:169: bad last GC pause: got 0, want [0, 10e9]
> FAIL
> FAIL    runtime 156.737s
> Build complete, duration 20m5.164s. Result: error: exit status 1
>
> https://codereview.appspot.com/128380043/

[gobot, 2014-08-19 11:15:24]

This CL appears to have broken the linux-and64-perf builder.
See http://build.golang.org/log/05d7e54c7616fad26edcc534107bb163a785dad0