code review 128310043: cmd/ld: fix operator precedence

cmd/ld: fix operator precedence

Fixes issue 8480.

This CL reapplies CL 114420043. This attempt doesn't blow up when encountering hidden symbols.

[dave_cheney.net, 2014-08-15 12:22:45]

Hello minux@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[minux, 2014-08-16 03:52:07]

LGTM.

[dave_cheney.net, 2014-08-16 04:04:02]

Submitting, here goes nothing.

On Sat, Aug 16, 2014 at 1:52 PM,  <minux@golang.org> wrote:
> LGTM.
>
> https://codereview.appspot.com/128310043/

[dave_cheney.net, 2014-08-16 04:10:50]

*** Submitted as https://code.google.com/p/go/source/detail?r=026598be012a ***

cmd/ld: fix operator precedence

Fixes issue 8480.

This CL reapplies CL 114420043. This attempt doesn't blow up when encountering
hidden symbols.

LGTM=minux
R=minux
CC=golang-codereviews
https://codereview.appspot.com/128310043

[gobot, 2014-08-16 04:28:36]

This CL appears to have broken the netbsd-386-minux builder.
See http://build.golang.org/log/c0918aed39fd6bc2cb4a63c248263bb1a0bd7fee

[dave_cheney.net, 2014-08-16 04:37:12]

Unrelated,

ok   net/url 0.003s
--- FAIL: TestKillFindProcess (4.08s)
os_test.go:1319: Test process succeeded, but expected to fail
FAIL
FAIL os 4.467s

On Sat, Aug 16, 2014 at 2:28 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the netbsd-386-minux builder.
> See http://build.golang.org/log/c0918aed39fd6bc2cb4a63c248263bb1a0bd7fee
>
> https://codereview.appspot.com/128310043/

[minux, 2014-08-16 04:39:34]

On Sat, Aug 16, 2014 at 12:37 AM, Dave Cheney <dave@cheney.net> wrote:

> Unrelated,
>
> ok   net/url 0.003s
> --- FAIL: TestKillFindProcess (4.08s)
> os_test.go:1319: Test process succeeded, but expected to fail
> FAIL
> FAIL os 4.467s

I used to believe such failures are due to bad interaction with tmux,
but the builder has been running inside GNU screen for a long time
now. I don't understand why it still happens occasionally, and it's not
very reproducible.