code review 12829048: freetype/truetype: implement ALIGNRP, MDAP and MDRP opcodes.

freetype/truetype: implement ALIGNRP, MDAP and MDRP opcodes.

We can now hint the .notdef glyph from luxisr.ttf. Yay.

[nigeltao, 2013-08-22 11:39:11]

Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/freetype-go

[bsiegert, 2013-08-26 19:00:21]

LGTM

Sorry for the wait. I was at a conference where internet was spotty.

https://codereview.appspot.com/12829048/diff/5001/freetype/truetype/hint.go
File freetype/truetype/hint.go (right):

https://codereview.appspot.com/12829048/diff/5001/freetype/truetype/hint.go#n...
freetype/truetype/hint.go:372: return errors.New("truetype: hinting: point out
of range")
You could use a constant value here to avoid repeating the literal string so
often. Something like a global

var ErrOutOfRange = errors.New("truetype: hinting: point out of range")

ditto below.

[nigeltao, 2013-08-31 06:09:32]

*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=30f4bf00ad3c ***

freetype/truetype: implement ALIGNRP, MDAP and MDRP opcodes.

We can now hint the .notdef glyph from luxisr.ttf. Yay.

R=bsiegert
CC=golang-dev
https://codereview.appspot.com/12829048