Issue 128290044: code review 128290044: go.sys/windows: delete errors_windows.go (except APPLIC...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 128290044: code review 128290044: go.sys/windows: delete errors_windows.go (except APPLIC... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by brainman

Modified:
11 years, 1 month ago

Reviewers:
r

CC:
golang-codereviews, r

Visibility:
Public.

Description

go.sys/windows: delete errors_windows.go (except APPLICATION_ERROR) and Errno All consts in errors_windows.go (except APPLICATION_ERROR) were "invented" at the start of windows port to have minimal impact on existing Go packages. No point keeping them around. Also remove Errno, since we will be using syscall.Errno everywhere anyway.

Patch Set 1 #

Patch Set 2 : diff -r 83b01791878338d00fb7163b2d49954f75b5c6f0 https://code.google.com/p/go.sys #

Patch Set 3 : diff -r 83b01791878338d00fb7163b2d49954f75b5c6f0 https://code.google.com/p/go.sys #

Patch Set 4 : diff -r 06c15ac12a3544809246eb42d92986c3ca18adc6 https://code.google.com/p/go.sys #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+289 lines, -599 lines)			Patch
M	windows/dll_windows.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
R	windows/errors_windows.go	View	1	1 chunk	+0 lines, -286 lines	0 comments	Download
M	windows/exec_windows.go	View	1	9 chunks	+9 lines, -8 lines	0 comments	Download
M	windows/security_windows.go	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	windows/syscall.go	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	windows/syscall_windows.go	View	1	18 chunks	+32 lines, -65 lines	0 comments	Download
M	windows/zsyscall_windows_386.go	View	1	117 chunks	+117 lines, -117 lines	0 comments	Download
M	windows/zsyscall_windows_amd64.go	View	1	117 chunks	+117 lines, -117 lines	0 comments	Download
M	windows/ztypes_windows.go	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

brainman

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.sys

11 years, 1 month ago (2014-08-15 01:07:50 UTC) #1

brainman

11 years, 1 month ago (2014-08-15 03:37:23 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=78a6277428dc&repo=sys ***

go.sys/windows: delete errors_windows.go (except APPLICATION_ERROR) and Errno

All consts in errors_windows.go (except APPLICATION_ERROR) were
"invented" at the start of windows port to have minimal impact on
existing Go packages. No point keeping them around.
Also remove Errno, since we will be using syscall.Errno everywhere anyway.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews
https://codereview.appspot.com/128290044

Expand All Messages | Collapse All Messages