Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(144)

Issue 128230045: code review 128230045: cmd/gc: fix heap buffer overflow (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by dvyukov
Modified:
10 years, 7 months ago
Reviewers:
rsc
CC:
rsc, r, iant, bradfitz, golang-codereviews
Visibility:
Public.

Description

cmd/gc: fix heap buffer overflow Fixes issue 8528.

Patch Set 1 #

Patch Set 2 : diff -r 2cc71cd8fe3e466a2338b1fdf8053931d47a9e31 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 2cc71cd8fe3e466a2338b1fdf8053931d47a9e31 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r d018c5d22f98912a80f1ec6add1d632acd0dbe47 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/cmd/gc/bv.c View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 5
dvyukov
Hello rsc@golang.org, r@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 7 months ago (2014-08-14 12:26:32 UTC) #1
rsc
LGTM
10 years, 7 months ago (2014-08-19 00:48:47 UTC) #2
bradfitz
Does this need to be applied to the Go 1.3 branch? On Mon, Aug 18, ...
10 years, 7 months ago (2014-08-19 00:57:20 UTC) #3
rsc
Eventually. It is not worth cutting a release unless someone runs into this for real. ...
10 years, 7 months ago (2014-08-19 00:58:30 UTC) #4
dvyukov
10 years, 7 months ago (2014-08-19 07:49:42 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=e34ca40b4857 ***

cmd/gc: fix heap buffer overflow
Fixes issue 8528.

LGTM=rsc
R=rsc, r, iant, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/128230045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b