code review 12814043: cmd/api: don't fail API check if there's no network

cmd/api: don't fail API check if there's no network

If the hg checkout of go.tools fails, check for Internet
connectivity before failing.

[bradfitz, 2013-08-12 23:13:16]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2013-08-12 23:15:33]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-08-12 23:15:38]

Nice.



On Mon, Aug 12, 2013 at 4:13 PM, <bradfitz@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> cmd/api: don't fail API check if there's no network
>
> If the hg checkout of go.tools fails, check for Internet
> connectivity before failing.
>
> Please review this at
https://codereview.appspot.**com/12814043/<https://codereview.appspot.com/128...
> Index: ~rietveld~placeholder~
> ==============================**==============================**=======
> diff --git a/~rietveld~placeholder~ b/~rietveld~placeholder~
> new file mode 100644
>
>
>

[shiv, 2013-08-13 01:25:03]

LGTM.

I like the simplicity of this fix with os.Exit(0) as against extra logic that I
suggested at https://groups.google.com/forum/#!topic/golang-nuts/xSEO5aFKesY

[bradfitz, 2013-08-13 02:18:54]

*** Submitted as https://code.google.com/p/go/source/detail?r=e1afe5447f6a ***

cmd/api: don't fail API check if there's no network

If the hg checkout of go.tools fails, check for Internet
connectivity before failing.

R=golang-dev, shivakumar.gn
CC=golang-dev
https://codereview.appspot.com/12814043