Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(412)

Issue 12808048: Completes the scale up UX

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by jeff.pihach
Modified:
10 years, 9 months ago
Reviewers:
mp+181620, rharding, matthew.scott
Visibility:
Public.

Description

Completes the scale up UX This branch adds the 'edit' step of the scale up story. The constraint fields on the overview page are databound so any changes to them will update behind the scenes. https://code.launchpad.net/~hatch/juju-gui/scale-up-pt2/+merge/181620 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Patch Set 2 : Completes the scale up UX #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -36 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/templates/service-constraints-viewlet.partial View 1 chunk +2 lines, -2 lines 0 comments Download
M app/templates/service-overview-constraints.handlebars View 1 chunk +24 lines, -19 lines 0 comments Download
M app/views/environment.js View 1 chunk +1 line, -1 line 0 comments Download
M app/views/inspector.js View 5 chunks +31 lines, -8 lines 0 comments Download
M lib/views/juju-inspector.less View 6 chunks +12 lines, -4 lines 0 comments Download
M test/test_inspector_constraints.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_inspector_overview.js View 3 chunks +44 lines, -1 line 0 comments Download

Messages

Total messages: 6
jeff.pihach
Please take a look.
10 years, 9 months ago (2013-08-22 16:54:44 UTC) #1
rharding
LGTM with note below. https://codereview.appspot.com/12808048/diff/1/app/views/inspector.js File app/views/inspector.js (right): https://codereview.appspot.com/12808048/diff/1/app/views/inspector.js#newcode155 app/views/inspector.js:155: this.overviewConstraintsEdit = false; should this ...
10 years, 9 months ago (2013-08-22 17:01:57 UTC) #2
jeff.pihach
Thanks for the review! https://codereview.appspot.com/12808048/diff/1/app/views/inspector.js File app/views/inspector.js (right): https://codereview.appspot.com/12808048/diff/1/app/views/inspector.js#newcode155 app/views/inspector.js:155: this.overviewConstraintsEdit = false; I was ...
10 years, 9 months ago (2013-08-22 17:10:02 UTC) #3
matthew.scott
LGTM - IE QA was okay, once caches were cleared. Several times. *fistshake* https://codereview.appspot.com/12808048/diff/1/test/test_inspector_overview.js File ...
10 years, 9 months ago (2013-08-22 17:24:25 UTC) #4
jeff.pihach
Thanks for the reviews!
10 years, 9 months ago (2013-08-22 17:32:51 UTC) #5
jeff.pihach
10 years, 9 months ago (2013-08-22 17:39:39 UTC) #6
*** Submitted:

Completes the scale up UX

This branch adds the 'edit' step of the scale up
story. The constraint fields on the overview page
are databound so any changes to them will update 
behind the scenes.

R=rharding, matthew.scott
CC=
https://codereview.appspot.com/12808048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b