Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(93)

Issue 12806043: Missing files from previous CL with fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by scottmg
Modified:
10 years, 8 months ago
CC:
angleproject-review_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/angle.git@add-trace-event
Visibility:
Public.

Description

Missing files from previous CL with fixes File adds got missed when landing https://codereview.appspot.com/12699047/, readded here. There was a crash when embedder's pointers for tracing weren't set, that's addressed here. The import/export is changed to not rely on __declspec(dllimport) and __declspec(dllexport), the setup function is extern "C" and included in the .def file so that the main project can GetProcAddress and not have a hard dependency on libGLESv2.dll. third_party/trace_event is the same as previous CL. R=apatrick@chromium.google.com,shannonwoods@google.com

Patch Set 1 #

Patch Set 2 : missing files and fixes #

Patch Set 3 : remove unnecessary defines #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+912 lines, -7 lines) Patch
M src/build_angle.gypi View 1 2 3 4 5 2 chunks +2 lines, -3 lines 0 comments Download
A src/common/event_tracer.h View 1 1 chunk +30 lines, -0 lines 0 comments Download
A src/common/event_tracer.cpp View 1 2 3 1 chunk +47 lines, -0 lines 0 comments Download
M src/libGLESv2/libGLESv2.def View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/libGLESv2/libGLESv2.vcxproj View 1 2 4 5 3 chunks +3 lines, -3 lines 0 comments Download
A src/third_party/trace_event/trace_event.h View 1 1 chunk +826 lines, -0 lines 0 comments Download

Messages

Total messages: 10
scottmg
10 years, 8 months ago (2013-08-12 21:43:48 UTC) #1
shannonwoods1
On 2013/08/12 21:43:48, scottmg wrote: Fix looks good to me. I can land this for ...
10 years, 8 months ago (2013-08-13 14:50:40 UTC) #2
scottmg
OK, updated to include files missed in last landing and to remove the dll futzing ...
10 years, 8 months ago (2013-08-13 16:55:21 UTC) #3
scottmg
On 2013/08/13 16:55:21, scottmg wrote: > OK, updated to include files missed in last landing ...
10 years, 8 months ago (2013-08-13 19:14:00 UTC) #4
shannonwoods1
On 2013/08/13 19:14:00, scottmg wrote: > On 2013/08/13 16:55:21, scottmg wrote: > > OK, updated ...
10 years, 8 months ago (2013-08-13 20:54:49 UTC) #5
scottmg
On 2013/08/13 20:54:49, shannonwoods1 wrote: > On 2013/08/13 19:14:00, scottmg wrote: > > On 2013/08/13 ...
10 years, 8 months ago (2013-08-13 23:22:03 UTC) #6
shannonwoods1
On 2013/08/13 23:22:03, scottmg wrote: > On 2013/08/13 20:54:49, shannonwoods1 wrote: > > On 2013/08/13 ...
10 years, 8 months ago (2013-08-13 23:53:08 UTC) #7
scottmg
On 2013/08/13 23:53:08, shannonwoods1 wrote: > On 2013/08/13 23:22:03, scottmg wrote: > > On 2013/08/13 ...
10 years, 8 months ago (2013-08-14 00:15:26 UTC) #8
Alok Priyadarshi
d206c85e27e1 indeed broke chrome. None of the shaders compile. I have verified that reverting that ...
10 years, 8 months ago (2013-08-14 04:44:10 UTC) #9
scottmg
10 years, 8 months ago (2013-08-14 04:53:49 UTC) #10
Message was sent while issue was closed.
On 2013/08/14 04:44:10, Alok Priyadarshi wrote:
> d206c85e27e1 indeed broke chrome. None of the shaders compile. I have verified
> that reverting that patch brings everything back to normal. I think we should
> revert it for now.

Shannon was going to revert d206c85e and land an updated version of this change
in the morning.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b