Issue 12802047: UI for switching namespaces

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12802047: UI for switching namespaces

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by ashu1461

Modified:
10 years, 9 months ago

Reviewers:
thomas.j.waldmann

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 2

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -0 lines)			Patch
	M	MoinMoin/apps/frontend/views.py	View		1 chunk	+14 lines, -0 lines	2 comments	Download
	A	MoinMoin/templates/namespace.html	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

ashu1461

https://codereview.appspot.com/12802047/diff/1/MoinMoin/apps/frontend/views.py File MoinMoin/apps/frontend/views.py (right): https://codereview.appspot.com/12802047/diff/1/MoinMoin/apps/frontend/views.py#newcode844 MoinMoin/apps/frontend/views.py:844: title_name=(u'Namespaces'), I tried using headline=_(u'Namespaces') here but it was ...

10 years, 9 months ago (2013-08-24 12:38:01 UTC) #1

Thomas.J.Waldmann

10 years, 9 months ago (2013-08-24 14:26:56 UTC) #2

https://codereview.appspot.com/12802047/diff/1/MoinMoin/apps/frontend/views.py
File MoinMoin/apps/frontend/views.py (right):

https://codereview.appspot.com/12802047/diff/1/MoinMoin/apps/frontend/views.p...
MoinMoin/apps/frontend/views.py:846: )
why is that a separate view?

do you expect people leave their current view to go to that "+namespace view"
first and then click on the namespace link there to end up where they wanted to
go in the first place?

even editing the url seems simpler than that.

this needs to get integrated into the theme, you can reuse some code of this to
do that.

Expand All Messages | Collapse All Messages